fix: more clippy warnings in sqlite and logger modules

- Fix match_like_matches_macro by using is_some() in logger.rs
- Fix needless_borrow warnings in sqlite/connection/execute.rs
- Fix ptr_arg by using slice instead of Vec reference
- Fix clone_on_copy by dereferencing instead of cloning
- Fix needless_return by removing redundant return keyword
- Fix explicit_counter_loop by using enumerate()

Author: cursoragent

sqlx-core/src/logger.rs

@@ -99,16 +99,11 @@ impl<'q, O: Debug + Hash + Eq, R: Debug, P: Debug> QueryPlanLogger<'q, O, R, P>
     }
 
     pub(crate) fn log_enabled(&self) -> bool {
-        if let Some(_lvl) = self
-            .settings
+        self.settings
             .statements_level
             .to_level()
             .filter(|lvl| log::log_enabled!(target: "sqlx::explain", *lvl))
-        {
-            true
-        } else {
-            false
-        }
+            .is_some()
     }
 
     pub(crate) fn add_result(&mut self, result: R) {

sqlx-core/src/sqlite/connection/execute.rs

@@ -83,7 +83,7 @@ impl Iterator for ExecuteIter<'_> {
 
             statement.handle.clear_bindings();
 
-            match bind(&mut statement.handle, self.args, self.args_used) {
+            match bind(statement.handle, &self.args, self.args_used) {
                 Ok(args_used) => self.args_used += args_used,
                 Err(e) => return Some(Err(e)),
             }
@@ -98,8 +98,8 @@ impl Iterator for ExecuteIter<'_> {
                 self.logger.increment_rows_returned();
 
                 Some(Ok(Either::Right(SqliteRow::current(
-                    &statement.handle,
-                    &statement.columns,
+                    statement.handle,
+                    statement.columns,
                     statement.column_names,
                 ))))
             }

sqlx-core/src/sqlite/connection/explain.rs

@@ -194,7 +194,7 @@ impl CursorDataType {
         )
     }
 
-    fn from_dense_record(record: &Vec<ColumnType>) -> Self {
+    fn from_dense_record(record: &[ColumnType]) -> Self {
         Self::Normal((0..).zip(record.iter().copied()).collect())
     }
 
@@ -203,7 +203,7 @@ impl CursorDataType {
             Self::Normal(record) => {
                 let mut rowdata = vec![ColumnType::default(); record.len()];
                 for (idx, col) in record.iter() {
-                    rowdata[*idx as usize] = col.clone();
+                    rowdata[*idx as usize] = *col;
                 }
                 rowdata
             }
@@ -306,7 +306,7 @@ fn root_block_columns(
         );
     }
 
-    return Ok(row_info);
+    Ok(row_info)
 }
 
 #[derive(Debug, Clone, PartialEq)]
@@ -666,7 +666,7 @@ pub(super) fn explain(
                     state.r.insert(
                         p2,
                         RegDataType::Single(ColumnType {
-                            datatype: opcode_to_type(&opcode),
+                                datatype: opcode_to_type(opcode),
                             nullable: Some(false),
                         }),
                     );
@@ -784,8 +784,7 @@ pub(super) fn explain(
     while let Some(state) = result_states.pop() {
         // find the datatype info from each ResultRow execution
         if let Some(result) = state.result {
-            let mut idx = 0;
-            for (this_type, this_nullable) in result {
+            for (idx, (this_type, this_nullable)) in result.into_iter().enumerate() {
                 if output.len() == idx {
                     output.push(this_type);
                 } else if output[idx].is_none()
@@ -804,7 +803,6 @@ pub(super) fn explain(
                 } else {
                     nullable[idx] = this_nullable;
                 }
-                idx += 1;
             }
         }
     }