fix: resolve large enum variant and naming warnings

- Box the TlsStream variant to reduce enum size
- Rename from_iter methods to avoid confusion with std trait
- Update all pattern matches to handle boxed variant

Author: cursoragent

sqlx-core/src/net/tls/mod.rs

@@ -98,7 +98,7 @@ where
     S: AsyncRead + AsyncWrite + Unpin,
 {
     Raw(S),
-    Tls(TlsStream<S>),
+    Tls(Box<TlsStream<S>>),
     Upgrading,
 }
 
@@ -135,24 +135,24 @@ where
             .map_err(|err| Error::Tls(err.into()))?
             .to_owned();
 
-        *self = MaybeTlsStream::Tls(connector.connect(host, stream).await?);
+        *self = MaybeTlsStream::Tls(Box::new(connector.connect(host, stream).await?));
 
         Ok(())
     }
 
     pub fn downgrade(&mut self) -> Result<(), Error> {
         match replace(self, MaybeTlsStream::Upgrading) {
-            MaybeTlsStream::Tls(stream) => {
+            MaybeTlsStream::Tls(mut boxed_stream) => {
                 #[cfg(feature = "_tls-rustls")]
                 {
-                    let raw = stream.into_inner().0;
+                    let raw = boxed_stream.into_inner().0;
                     *self = MaybeTlsStream::Raw(raw);
                     Ok(())
                 }
 
                 #[cfg(feature = "_tls-native-tls")]
                 {
-                    let _ = stream; // Use the variable to avoid warning
+                    let _ = boxed_stream; // Use the variable to avoid warning
                     return Err(Error::tls("No way to downgrade a native-tls stream, use rustls instead, or never disable tls"));
                 }
             }
@@ -216,7 +216,7 @@ where
     ) -> Poll<io::Result<super::PollReadOut>> {
         match &mut *self {
             MaybeTlsStream::Raw(s) => Pin::new(s).poll_read(cx, buf),
-            MaybeTlsStream::Tls(s) => Pin::new(s).poll_read(cx, buf),
+            MaybeTlsStream::Tls(s) => Pin::new(&mut **s).poll_read(cx, buf),
 
             MaybeTlsStream::Upgrading => Poll::Ready(Err(io::ErrorKind::ConnectionAborted.into())),
         }
@@ -234,7 +234,7 @@ where
     ) -> Poll<io::Result<usize>> {
         match &mut *self {
             MaybeTlsStream::Raw(s) => Pin::new(s).poll_write(cx, buf),
-            MaybeTlsStream::Tls(s) => Pin::new(s).poll_write(cx, buf),
+            MaybeTlsStream::Tls(s) => Pin::new(&mut **s).poll_write(cx, buf),
 
             MaybeTlsStream::Upgrading => Poll::Ready(Err(io::ErrorKind::ConnectionAborted.into())),
         }
@@ -243,7 +243,7 @@ where
     fn poll_flush(mut self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<io::Result<()>> {
         match &mut *self {
             MaybeTlsStream::Raw(s) => Pin::new(s).poll_flush(cx),
-            MaybeTlsStream::Tls(s) => Pin::new(s).poll_flush(cx),
+            MaybeTlsStream::Tls(s) => Pin::new(&mut **s).poll_flush(cx),
 
             MaybeTlsStream::Upgrading => Poll::Ready(Err(io::ErrorKind::ConnectionAborted.into())),
         }
@@ -253,7 +253,7 @@ where
     fn poll_shutdown(mut self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<io::Result<()>> {
         match &mut *self {
             MaybeTlsStream::Raw(s) => Pin::new(s).poll_shutdown(cx),
-            MaybeTlsStream::Tls(s) => Pin::new(s).poll_shutdown(cx),
+            MaybeTlsStream::Tls(s) => Pin::new(&mut **s).poll_shutdown(cx),
 
             MaybeTlsStream::Upgrading => Poll::Ready(Err(io::ErrorKind::ConnectionAborted.into())),
         }
@@ -263,7 +263,7 @@ where
     fn poll_close(mut self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<io::Result<()>> {
         match &mut *self {
             MaybeTlsStream::Raw(s) => Pin::new(s).poll_close(cx),
-            MaybeTlsStream::Tls(s) => Pin::new(s).poll_close(cx),
+            MaybeTlsStream::Tls(s) => Pin::new(&mut **s).poll_close(cx),
 
             MaybeTlsStream::Upgrading => Poll::Ready(Err(io::ErrorKind::ConnectionAborted.into())),
         }

sqlx-core/src/postgres/message/parse.rs

@@ -1,4 +1,3 @@
-
 use crate::io::{BufMutExt, Encode};
 use crate::postgres::io::PgBufMutExt;
 use crate::postgres::types::Oid;

sqlx-core/src/postgres/types/lquery.rs

@@ -75,7 +75,7 @@ impl PgLQuery {
     }
 
     /// creates lquery from an iterator with checking labels
-    pub fn from_iter<I, S>(levels: I) -> Result<Self, PgLQueryParseError>
+    pub fn from_level_iter<I, S>(levels: I) -> Result<Self, PgLQueryParseError>
     where
         S: Into<String>,
         I: IntoIterator<Item = S>,

sqlx-core/src/postgres/types/ltree.rs

@@ -103,7 +103,7 @@ impl PgLTree {
     }
 
     /// creates ltree from an iterator with checking labels
-    pub fn from_iter<I, S>(labels: I) -> Result<Self, PgLTreeParseError>
+    pub fn from_label_iter<I, S>(labels: I) -> Result<Self, PgLTreeParseError>
     where
         String: From<S>,
         I: IntoIterator<Item = S>,