fix: update lint configurations and suppress unused import warnings in tests

- Added 'cfg(postgres_9_6)' to the lint configuration in Cargo.toml.
- Suppressed unused import warnings in various test files for better clarity and maintainability.
- Adjusted assertions in MySQL tests for boolean values to use assert! macro.

Author: lovasoa

Cargo.toml

@@ -19,7 +19,7 @@ members = [
 ]
 
 [workspace.lints.rust]
-unexpected_cfgs = { level = "warn", check-cfg = ['cfg(postgres_14)'] }
+unexpected_cfgs = { level = "warn", check-cfg = ['cfg(postgres_14)', 'cfg(postgres_9_6)'] }
 
 [package]
 name = "sqlx-oldapi"

tests/any/pool.rs

@@ -1,5 +1,6 @@
+#[allow(unused_imports)]
 use sqlx_oldapi::any::{AnyConnectOptions, AnyPoolOptions};
-use sqlx_oldapi::Executor;
+#[allow(unused_imports)]
 use std::sync::atomic::AtomicI32;
 use std::sync::{
     atomic::{AtomicUsize, Ordering},

tests/mssql/mssql.rs

@@ -1,11 +1,14 @@
 use futures::TryStreamExt;
 use sqlx_core::mssql::MssqlRow;
+#[allow(unused_imports)]
 use sqlx_oldapi::mssql::{Mssql, MssqlPoolOptions};
 use sqlx_oldapi::{
-    Column, Connection, Execute, Executor, MssqlConnection, Row, Statement, TypeInfo,
+    Column, Connection, Executor, MssqlConnection, Row, Statement, TypeInfo,
 };
 use sqlx_test::new;
+#[allow(unused_imports)]
 use std::sync::atomic::{AtomicI32, Ordering};
+#[allow(unused_imports)]
 use std::time::Duration;
 
 #[sqlx_macros::test]

tests/mssql/types.rs

@@ -99,9 +99,9 @@ test_type!(numeric<f64>(Mssql,
     "CAST(0.0000000000000001 AS NUMERIC(38,16))" == 0.0000000000000001_f64,
     "CAST(939399419.1225182 AS NUMERIC(15,2))" == 939399419.12_f64,
     "CAST(939399419.1225182 AS DECIMAL(15,2))" == 939399419.12_f64,
-    "CAST(123456789.0123456789 AS NUMERIC(38,10))" == 123_456_789.012_345_678_9_f64,
-    "CAST(123456789.0123456789012 AS NUMERIC(38,13))" == 123_456_789.012_345_678_901_2_f64,
-    "CAST(123456789.012345678901234 AS NUMERIC(38,15))" == 123_456_789.012_345_678_901_234_f64,
+    "CAST(123456789.0123456789 AS NUMERIC(38,10))" == 123_456_789.012_345_67_f64,
+    "CAST(123456789.0123456789012 AS NUMERIC(38,13))" == 123_456_789.012_345_67_f64,
+    "CAST(123456789.012345678901234 AS NUMERIC(38,15))" == 123_456_789.012_345_67_f64,
     "CAST(1.0000000000000001 AS NUMERIC(18,16))" == 1.0000000000000001_f64,
     "CAST(0.99999999999999 AS NUMERIC(18,14))" == 0.99999999999999_f64,
     "CAST(2.00000000000001 AS NUMERIC(18,14))" == 2.00000000000001_f64,
@@ -265,8 +265,8 @@ mod decimal {
         "CAST('-1.0000' AS MONEY)" == -1.0000,
         "CAST('2.15' AS MONEY)" == 2.15,
         "CAST('214748.3647' AS SMALLMONEY)" == 214748.3647,
-        "CAST('922337203685477.5807' AS MONEY)" == 922337203685477.5807,
-        "CAST('-922337203685477.5808' AS MONEY)" == -922337203685477.5808,
+        "CAST('922337203685477.5807' AS MONEY)" == 922_337_203_685_477.6,
+        "CAST('-922337203685477.5808' AS MONEY)" == -922_337_203_685_477.6,
         "CAST('214748.3647' AS SMALLMONEY)" == 214748.3647,
         "CAST('-214748.3648' AS SMALLMONEY)" == -214748.3648,
     ));

tests/mysql/types.rs

@@ -1,3 +1,5 @@
+#![allow(clippy::approx_constant)]
+
 extern crate time_ as time;
 
 #[cfg(feature = "decimal")]
@@ -331,7 +333,7 @@ CREATE TEMPORARY TABLE with_bits (
     // as bool
     let row = conn.fetch_one("SELECT value_1 FROM with_bits").await?;
     let v1: bool = row.try_get(0)?;
-    assert_eq!(v1, true);
+    assert!(v1);
 
     // switch the bit
     sqlx_oldapi::query("UPDATE with_bits SET value_1 = NOT value_1")
@@ -340,7 +342,7 @@ CREATE TEMPORARY TABLE with_bits (
 
     let row = conn.fetch_one("SELECT value_1 FROM with_bits").await?;
     let v1: bool = row.try_get(0)?;
-    assert_eq!(v1, false);
+    assert!(!v1);
 
     Ok(())
 }

tests/postgres/types.rs

@@ -1,3 +1,4 @@
+#![allow(unexpected_cfgs)]
 extern crate time_ as time;
 
 use std::ops::Bound;

tests/sqlite/types.rs

@@ -1,8 +1,9 @@
 #![allow(clippy::approx_constant)]
 extern crate time_ as time;
 
-use sqlx_core::row::Row;
+#[allow(unused_imports)]
 use sqlx_oldapi::sqlite::{Sqlite, SqliteRow};
+#[allow(unused_imports)]
 use sqlx_test::new;
 use sqlx_test::test_type;