Change scene update logic to use new scene api#107
Open
torandi wants to merge 1 commit intosqmk:masterfrom
Open
Change scene update logic to use new scene api#107torandi wants to merge 1 commit intosqmk:masterfrom
torandi wants to merge 1 commit intosqmk:masterfrom
Conversation
Use scene api 1.29, reduces load on hub when setting many lights.
Owner
|
Right on. I'll check out the API changes and try to get Huejay in sync. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API 1.29 introduced a way of updating all lights in a scene in one go.
This PR changes the scene update logic to use that.
I haven't deleted the old SaveSceneLightState in this PR, as it could be use as a fallback if you desire to support the old api as well.
My main reason for this fix is that updating all lights in a large scene results in 500 or connection reset from the hub, as it get's too many requests in a short time.