Add ability to use Philips' remote API#111
Open
codetheweb wants to merge 6 commits intosqmk:masterfrom
Open
Conversation
RawGit is shutting down: https://rawgit.com/
Owner
|
Thanks for the submission. I'd prefer to go the route of using the strategy pattern and having two classes handling remote and local API calls. Some of your work will be useful for that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to use the Remote API that Philips provides, as well as a few small bug fixes.
The Remote API is virtually identical to the local bridge API, which made it very easy to add with minimal changes.
In addition, I fixed a few issues:
package-lock.jsonfrom the.gitignore, as NPM recomends that it be committed to version control. (However, after looking at it more the Node.js community seems to be a bit split over whether or not it should be included. I personally think it makes sense but if you want it to be ignored I can revert that change.)Finally, if you're open to it I'd like to add a linter for the sake of consistent code styling (perhaps in a different PR). I have no personal preference for a specific linter, but I use XO for my projects which has sensible defaults.
This is my first time contributing to this project, so please let me know if I need to rework something or I didn't structure it quite right.