Skip to content

Minor updates#2631

Open
Goooler wants to merge 113 commits intosquare:mainfrom
Goooler:main
Open

Minor updates#2631
Goooler wants to merge 113 commits intosquare:mainfrom
Goooler:main

Conversation

@Goooler
Copy link
Contributor

@Goooler Goooler commented Feb 4, 2024

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Goooler
❌ renovate[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

public static final field MESSAGE_QUEUE Lshark/AndroidReferenceReaders;
public static final field SAFE_ITERABLE_MAP Lshark/AndroidReferenceReaders;
public synthetic fun <init> (Ljava/lang/String;ILkotlin/jvm/internal/DefaultConstructorMarker;)V
public static fun getEntries ()Lkotlin/enums/EnumEntries;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's up with this new API showing up everywhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pyricau
Copy link
Member

pyricau commented Feb 16, 2024

"Minor updates" => this is a giant PR, hard to review. I appreciate your help in keeping this repo up to date, but going forward would you mind making small indepandant PRs?

@pyricau
Copy link
Member

pyricau commented Feb 16, 2024

@Goooler Would you mind rebasing & solving the conflict? Also, do you have any idea how to get renovate[bot] to play nice with CLA Assistant?

@pyricau pyricau closed this Feb 16, 2024
@pyricau pyricau reopened this Feb 16, 2024
@pyricau
Copy link
Member

pyricau commented Feb 16, 2024

(oops sorry didn't mean to close, wrong button)

renovate bot and others added 26 commits February 17, 2024 10:28
* Update workManager to v2.9.0

* Fix FakeAppContextConfigurationProvider

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Goooler <wangzongler@gmail.com>
@TimoPtr
Copy link

TimoPtr commented Jul 3, 2025

@pyricau any plan on moving forward with this PR? I would like to help bumping the target to API 36 and this would help moving forward.

@TimoPtr
Copy link

TimoPtr commented Jul 3, 2025

Also how confident are you about the bump of the Kotlin version since I saw this comment

# We would like to use Kotlin recent language features but keep Kotlin 1.3 library APIs
# The benefit is that depending clients do not have to upgrade to Kotlin 1.4

@Goooler
Copy link
Contributor Author

Goooler commented Jul 3, 2025

It would be great to enable @renovate-bot for this repo, like other Squares' repos do. Updates will be sent, and we can merge them one by one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants