Skip to content

Update BridgeInterceptor.kt #8586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GeorgCantor wants to merge 1 commit into from
Closed

Update BridgeInterceptor.kt #8586

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions okhttp/src/main/kotlin/okhttp3/internal/http/BridgeInterceptor.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,11 +110,7 @@ class BridgeInterceptor(private val cookieJar: CookieJar) : Interceptor {
}

/** Returns a 'Cookie' HTTP request header with all cookies, like `a=b; c=d`. */
private fun cookieHeader(cookies: List<Cookie>): String =
buildString {
cookies.forEachIndexed { index, cookie ->
if (index > 0) append("; ")
append(cookie.name).append('=').append(cookie.value)
}
}
private fun cookieHeader(cookies: List<Cookie>): String {
return cookies.joinToString("; ") { "${it.name}=${it.value}" }
Copy link
Collaborator

@JakeWharton JakeWharton Nov 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately this creates a nested StringBuilder for each name/value pair before adding it to an enclosing one, whereas the old code only uses a single one for all pairs.

}
}