Skip to content

Fix JavaHttpClientTest #9265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yschimke merged 1 commit into from
Jan 25, 2026
+0 −4
Merged

Fix JavaHttpClientTest #9265

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions samples/compare/src/test/kotlin/okhttp3/compare/JavaHttpClientTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ import mockwebserver3.MockResponse
import mockwebserver3.MockWebServer
import mockwebserver3.junit5.StartStop
import okhttp3.testing.PlatformRule
import okhttp3.testing.PlatformVersion
import org.junit.jupiter.api.Test
import org.junit.jupiter.api.extension.RegisterExtension

Expand Down Expand Up @@ -77,9 +76,6 @@ class JavaHttpClientTest {
assertThat(recorded.headers["Accept"]).isEqualTo("text/plain")
assertThat(recorded.headers["Accept-Encoding"]).isNull() // No built-in gzip.
assertThat(recorded.headers["Connection"]).isEqualTo("Upgrade, HTTP2-Settings")
if (PlatformVersion.majorVersion < 19) {
assertThat(recorded.headers["Content-Length"]).isEqualTo("0")
}
assertThat(recorded.headers["HTTP2-Settings"]).isNotNull()
assertThat(recorded.headers["Upgrade"]).isEqualTo("h2c") // HTTP/2 over plaintext!
assertThat(recorded.headers["User-Agent"]!!).matches(Regex("Java-http-client/.*"))
Expand Down
Loading