Enable Gradle Configuration Cache — by refactoring OSGi/BND plugin#9310
Merged
yschimke merged 4 commits intosquare:masterfrom Feb 5, 2026
Merged
Enable Gradle Configuration Cache — by refactoring OSGi/BND plugin#9310yschimke merged 4 commits intosquare:masterfrom
yschimke merged 4 commits intosquare:masterfrom
Conversation
This commit enables Gradle's Configuration Cache feature, which was blocked by the BND (OSGi bundle) plugin's incompatibility. The key changes are: - A new `BndBuildAction` class is introduced. This class is a static, configuration-cache-compatible replacement for the BND plugin's default build action. - The `Osgi.kt` build logic is refactored to use this new `BndBuildAction` instead of directly calling the BND plugin's action, which was not serializable. - The `STABLE_CONFIGURATION_CACHE` feature preview is enabled in `settings.gradle.kts`. - Gradle properties are updated to enable the configuration cache (`org.gradle.configuration-cache=true`).
Collaborator
Author
|
@swankjesse you touched this last, so may have a good idea. BndBuildAction edits were AI assisted, so I'm somewhat relying on tests. |
Collaborator
Author
|
@swankjesse requesting post review - want to have a strict build while I make any follow up changes. decent chance I need to revert this or fix forward based on your bnd review. But tests are passing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit enables Gradle's Configuration Cache feature — which was blocked by the BND (OSGi bundle) plugin's incompatibility.
The key changes are:
BndBuildActionclass is introduced. This class is a static, configuration-cache-compatible replacement for the BND plugin's default build action.Osgi.ktbuild logic is refactored to use this newBndBuildActioninstead of directly calling the BND plugin's action, which was not serializable.STABLE_CONFIGURATION_CACHEfeature preview is enabled insettings.gradle.kts.org.gradle.configuration-cache=true).