WIP improve visualizer usability #1382
Open
+1,300
−234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using reflection gives us the declared fields of a class only in alphabetical order, and some information is unnecessarily inside, so we instead just manually give back a list and the data associated with them through companion methods.
The only important fields of a node is its state, props, and rendering. Its and the parent node's ID's are less significant, and have been moved out of their own detailed cards to avoid cluttering up the info panel
All simple nodes (with no children) are shown at the top and nested nodes (with children) are shown at the bottom. This makes it the nesting more clear.
wenli-cai
force-pushed
the
wenli/improve-visualizer
branch
from
e73317b to
5ec8a18
Compare
wenli-cai
commented
Jul 26, 2025
| builder.pushStyle(style) | ||
| builder.append(text) | ||
| builder.pop() | ||
| } |
There was a problem hiding this comment.
Having a helper function like this makes it very easy to understand what these three lines are doing, but having to list out the arguments (line 38 vs 43) ends up taking 5 lines instead of 3. Is this a worth it trade off?
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
wenli-cai
force-pushed
the
wenli/improve-visualizer
branch
from
bb01fc9 to
cdfbc82
Compare
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
The goal is to have the viewport snap to the node when it's being searched for, but current use of Offset seems to give some positional errors.
wenli-cai
force-pushed
the
wenli/improve-visualizer
branch
from
835349b to
a9a44e9
Compare
wenli-cai
force-pushed
the
wenli/improve-visualizer
branch
2 times, most recently
from
59d285a to
ff128a8
Compare
wenli-cai
force-pushed
the
wenli/improve-visualizer
branch
from
ff128a8 to
7b7b41a
Compare
wenli-cai
force-pushed
the
wenli/improve-visualizer
branch
from
8745914 to
a489f00
Compare
wenli-cai
force-pushed
the
wenli/improve-visualizer
branch
from
83502fe to
08f412c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
todo