Skip to content

Move workflow-runtime-android into android source set in workflow-runtime module. (2nd attempt) #1445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zach-klippenstein merged 1 commit into from
Jan 28, 2026
Merged

Move workflow-runtime-android into android source set in workflow-runtime module. (2nd attempt) #1445

zach-klippenstein merged 1 commit into from
Jan 28, 2026
+624 −165

Conversation

@zach-klippenstein
Copy link
Collaborator

@zach-klippenstein zach-klippenstein commented Jan 27, 2026

First attempt was #1370, but got reverted in #1378 due to it having broken something.

I need this in order to correctly consume Compose Multiplatform for the work migrating the runtime to compose (#1442).

This reverts commit 58c1d40.

@zach-klippenstein zach-klippenstein requested a review from a team as a code owner January 27, 2026 00:33
@zach-klippenstein
Copy link
Collaborator Author

zach-klippenstein commented Jan 27, 2026 •
edited
Loading

  • Make sure all the tests that got moved are still running in CI

@zach-klippenstein zach-klippenstein force-pushed the zachklipp/workflow-runtime-kmp branch from 1dda1a8 to c836ba9 Compare January 27, 2026 22:25
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 27, 2026
View reviewed changes
@zach-klippenstein zach-klippenstein force-pushed the zachklipp/workflow-runtime-kmp branch from 32407d5 to c747ad6 Compare January 27, 2026 22:42
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 27, 2026
View reviewed changes
@zach-klippenstein zach-klippenstein force-pushed the zachklipp/workflow-runtime-kmp branch from c747ad6 to 4faa7b0 Compare January 27, 2026 22:57
@zach-klippenstein
Copy link
Collaborator Author

zach-klippenstein commented Jan 27, 2026 •
edited
Loading

  • Make sure all the tests that got moved are still running in CI

Commit d721fa8 includes a test that fails on purpose, and this CI build shows it failing and being reported in CI.

@zach-klippenstein zach-klippenstein force-pushed the zachklipp/workflow-runtime-kmp branch from 4faa7b0 to 9ef267c Compare January 27, 2026 23:05
@zach-klippenstein

This comment was marked as resolved.

Sign in to view
@zach-klippenstein zach-klippenstein force-pushed the zachklipp/workflow-runtime-kmp branch 7 times, most recently from d721fa8 to 70e4088 Compare January 28, 2026 00:31
@zach-klippenstein

This comment was marked as resolved.

Sign in to view
@zach-klippenstein zach-klippenstein force-pushed the zachklipp/workflow-runtime-kmp branch from 70e4088 to 992f530 Compare January 28, 2026 01:04
@zach-klippenstein
Move workflow-runtime-android into android source set in workflow-run…
9357ffd 
…time module. (2nd attempt)

First attempt was #1370, but got reverted in
#1378 due to it having broken something.

I need this in order to correctly consume Compose Multiplatform for the work migrating
the runtime to compose (#1442).

This reverts commit 58c1d40.
@zach-klippenstein zach-klippenstein force-pushed the zachklipp/workflow-runtime-kmp branch from 992f530 to 9357ffd Compare January 28, 2026 01:05
steve-the-edwards
steve-the-edwards approved these changes Jan 28, 2026
View reviewed changes
Copy link
Contributor

@steve-the-edwards steve-the-edwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to make a new convention plugin for android-multiplatform that includes the android plugin.

workflow-runtime/build.gradle.kts
Comment on lines +7 to +8
id("com.android.kotlin.multiplatform.library")
// This is our own convention plugin, not the standard one.
Copy link
Contributor

@steve-the-edwards steve-the-edwards Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ultimately we probably want to integrate this into our own android-multiplatform convention plugin. Is there a reason that is too difficult to do now?

Copy link
Collaborator Author

@zach-klippenstein zach-klippenstein Jan 28, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also realized we'd probably want to move it to a plugin, but I believe this is the only KMP module we have that targets android right now so I was thinking rule-of-three. The configuration is pretty straightforward so I don't think it should be too hard to clone the existing android one and modify it for KMP.

@zach-klippenstein zach-klippenstein merged commit a013f39 into main Jan 28, 2026
74 checks passed
@zach-klippenstein zach-klippenstein deleted the zachklipp/workflow-runtime-kmp branch January 28, 2026 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@steve-the-edwards steve-the-edwards steve-the-edwards approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zach-klippenstein @steve-the-edwards