fix: Use TARGETARCH for multi-platform builds #405
+3
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enable ARM64 and other architecture support by using Docker's automatic
TARGETARCHvariable instead of hardcodedGOARCH=amd64.Problem
The current Dockerfile hardcodes
ARG GOARCH=amd64, which prevents building images for other architectures likearm64usingdocker buildx build --platform linux/arm64.Solution
TARGETARCHwhich is automatically set by Docker buildx during multi-platform buildsamd64for backward compatibility with non-buildx buildsChanges
Testing
Build for multiple platforms:
docker buildx build --platform linux/amd64,linux/arm64 -t kilo:test .