This repository was archived by the owner on Apr 9, 2024. It is now read-only.
File checker rework: a) bugs fixed, b) more robust detection, c) many tests added.#149
Open
TobiasKnauss wants to merge 3 commits intosquid-box:devfrom
Open
File checker rework: a) bugs fixed, b) more robust detection, c) many tests added.#149TobiasKnauss wants to merge 3 commits intosquid-box:devfrom
TobiasKnauss wants to merge 3 commits intosquid-box:devfrom
Conversation
Formats partly reworked. DuplicateKeyComparer added. IEnumerableHelper added. All 180 Tests passed successfully.
TobiasKnauss
changed the title
Owner
|
It's been a while since I actively worked on this, sorry about that. I like the overall gist of the PR, but given the changes that have been introduced since it was created it's not as straight forward as just accepting it. I've made a note to go through this and try to align these changes with the current state of my code base - but I can't promise a date when it's done. If you have time / feel like resolving the merge conflicts I'll include it, otherwise I'll resolve them at some point and include this then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many tests added, especially for TAR archives, because the old FileChecker was faulty, because it detected many TAR archives as something else.
The FileChecker class has been reworked completely to achieve a correct and more robust archive format detection.
bugfix: SevenZipSharp fails to unpack certain tar archives.
https://stackoverflow.com/questions/53323255/sevenzipsharp-fails-to-unpack-certain-tar-archives