-
Notifications
You must be signed in to change notification settings - Fork 10
fix misspells and minor cleanup #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MFTabriz
wants to merge
4
commits into
squid-cache:main
Choose a base branch
from
MFTabriz:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -104,7 +104,7 @@ First, build and install dependencies: | |||||
| make -j8 | ||||||
| make install | ||||||
|
|
||||||
| Make shure all shared libraries are installed. | ||||||
| Make sure all shared libraries are installed. | ||||||
|
|
||||||
| > :information_source: | ||||||
| Note: Use correct compiler full path, depending your setup. Commands | ||||||
|
|
@@ -145,7 +145,7 @@ Supported configuration parameters: | |||||
| Files with size greater than limit will be stored in temporary | ||||||
| disk storage, otherwise processing will be done in RAM. | ||||||
| exclude_types | ||||||
| List of semicolon seprated MIME types which shouldn't be | ||||||
| List of semicolon separated MIME types which shouldn't be | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. contraction
Suggested change
|
||||||
| handled by adapter. | ||||||
|
|
||||||
| ## Squid Configuration File | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -17,7 +17,7 @@ organised... | |||||
| 14:49 < nicholas> Ok, that's client streams. | ||||||
| 14:49 < lifeless> the fwdState api is on the wrong side of the store | ||||||
| 14:49 < nicholas> doh! | ||||||
| 14:49 < lifeless> so it doesn't have any of the required logic - cachability, vary handling, updates of existing opbjects... | ||||||
| 14:49 < lifeless> so it doesn't have any of the required logic - cachability, vary handling, updates of existing objects... | ||||||
| 14:50 < lifeless> things like store digests just haven't been updated to use client streams yet. | ||||||
| 14:50 < nicholas> What, concisely, is a store digest? | ||||||
| 14:51 < lifeless> a bitmap that lossilly represents the contents of an entire squid cache, biased to hits. | ||||||
|
|
@@ -49,7 +49,7 @@ organised... | |||||
| 15:02 < lifeless> well you don't want that. | ||||||
| 15:02 < lifeless> because you don't want to parse requests. | ||||||
| 15:02 < lifeless> ClientSocketContext is likely to be the closest thing to what you want though. | ||||||
| 15:03 < lifeless> so your readfunc needs to eat all the data it recieves. | ||||||
| 15:03 < lifeless> so your readfunc needs to eat all the data it receives. | ||||||
| 15:04 < lifeless> you can throw it away. | ||||||
| 15:04 < lifeless> your detach function can just call clientStreamDetach(node, http); | ||||||
| 15:04 < nicholas> so do I add my function into ClientSocketContext's read function? | ||||||
|
|
@@ -85,7 +85,7 @@ organised... | |||||
| 15:13 < nicholas> stream.getRaw() is a pointer to the node, yes? I could the code around that confusing. | ||||||
| 15:14 < lifeless> stream is a ESIStreamContext which is a clientStream node that pulls data from a clientstream, instances of which are | ||||||
| used by both the master esi document and includes | ||||||
| 15:14 < lifeless> (different instances, but hte logic is shared by composition) | ||||||
| 15:14 < lifeless> (different instances, but the logic is shared by composition) | ||||||
| 15:14 < lifeless> that is pased into ESIInclude::Start because ESI includes have a primary include and an 'alternate' include. | ||||||
| 15:16 < lifeless> so all you need to start the chain is: | ||||||
| 15:16 < nicholas> I see. I won't need to worry about any of that. | ||||||
|
|
@@ -130,7 +130,7 @@ organised... | |||||
| 15:25 < lifeless> and likewise for the Detach static method | ||||||
| 15:26 < lifeless> is this making sense ? | ||||||
| 15:27 < nicholas> yes, but just let me reread a litt.e | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. typo
Suggested change
|
||||||
| 15:27 < lifeless> ok, theres one more important thing :) | ||||||
| 15:27 < lifeless> ok, there's one more important thing :) | ||||||
| 15:27 < nicholas> "static_cast<myStream *>(node->data)->bufferData(node, ...)" calls myStream::BufferData doesn't it? So why am I calling | ||||||
| myself? | ||||||
| 15:28 < lifeless> lowercase bufferData :) | ||||||
|
|
@@ -189,7 +189,7 @@ organised... | |||||
| 15:38 < lifeless> so right before that #if ESI line. | ||||||
| 15:39 < nicholas> Oh, I see it has the body at this point already? | ||||||
| 15:39 < nicholas> Or does it just have a partial body? | ||||||
| 15:39 < lifeless> it may have some body, but it definately has the reply metadata | ||||||
| 15:39 < lifeless> it may have some body, but it definitely has the reply metadata | ||||||
| 15:39 < nicholas> Because my code is rigged to work with partial data. | ||||||
| 15:39 < nicholas> ok, good. | ||||||
| 15:39 < nicholas> Then that's *exactly* right. | ||||||
|
|
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.