Skip to content

Fix typo in LIBMIT_KRB5 variable naming #2335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
timp87 wants to merge 1 commit into from
Closed

Fix typo in LIBMIT_KRB5 variable naming #2335

timp87 wants to merge 1 commit into from
+1 −1

Conversation

@timp87
Copy link
Contributor

@timp87 timp87 commented Jan 5, 2026 •
edited by rousskov
Loading

Discovered while porting Squid v7 to FreeBSD.

configure.ac: rename LIB_KRB5 to LIBMIT_KRB5
98137ac 
Looking at the resulting configure script I believe this was a typo
@yadij yadij changed the title configure.ac: rename LIB_KRB5 to LIBMIT_KRB5 Fix typo in LIBMIT_KRB5 variable naming Jan 5, 2026
@yadij yadij added M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels S-could-use-an-approval An approval may speed this PR merger (but is not required) backport-to-v7 maintainer has approved these changes for v7 backporting labels Jan 5, 2026
rousskov
rousskov reviewed Jan 5, 2026
View reviewed changes
Copy link
Contributor

@rousskov rousskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timp87, thank you for fixing this! We fixed (and discovered) the same bug during recent #2320 work, but that PR has not been merged yet, and it is probably best to merge your smaller/focused PR first.

When you were porting Squid v7 to FreeBSD, how did this typo manifest itself? In other words, what were the symptoms of this bug that draw your attention to it?

I tried to identify the commit that broke this, but I could not do it quickly with enough certainty. AFAICT, the first explicit mention of LIBMIT_KRB5 happened in 2024 commit d99af84, but it is possible that a different commit is responsible.

I adjusted PR description (i.e. the future official commit message), primarily to avoid duplicating PR title (adjusted earlier by Amos).

@rousskov rousskov removed the M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels label Jan 5, 2026
@yadij yadij mentioned this pull request Jan 5, 2026
Open
@timp87
Copy link
Contributor Author

timp87 commented Jan 5, 2026

Similar to #2337 (comment)
On FreeBSD 15 I couldn't make configure pickup MIT KRB5 included into the FreeBSD base.

@rousskov rousskov added the M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels label Jan 5, 2026
squid-anubis pushed a commit that referenced this pull request Jan 7, 2026
@timp87 @squid-anubis
Fix typo in LIBMIT_KRB5 variable naming (#2335)
1009142 
Discovered while porting Squid v7 to FreeBSD.
@squid-anubis squid-anubis added the M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels label Jan 7, 2026
@squid-anubis squid-anubis added M-merged https://github.com/measurement-factory/anubis#pull-request-labels and removed M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels labels Jan 7, 2026
squidadm pushed a commit to squidadm/squid that referenced this pull request Jan 7, 2026
@timp87 @squidadm
Fix typo in LIBMIT_KRB5 variable naming (squid-cache#2335)
e1da6e4 
Discovered while porting Squid v7 to FreeBSD.
@yadij yadij removed S-could-use-an-approval An approval may speed this PR merger (but is not required) backport-to-v7 maintainer has approved these changes for v7 backporting labels Jan 7, 2026
@timp87
Copy link
Contributor Author

timp87 commented Jan 7, 2026

@rousskov @yadij sorry to bother you. It would be nice if it was backported to v7

@rousskov
Copy link
Contributor

rousskov commented Jan 7, 2026

@rousskov @yadij sorry to bother you. It would be nice if it was backported to v7

Backport is already in progress at #2339. Backporting process/automation is undergoing changes right now, triggering some noise and delays, but all of that is unrelated to your work and this specific PR. The ball is on our side.

@timp87
Copy link
Contributor Author

timp87 commented Jan 7, 2026

Ok, just didn't see a message from the bot about backport queueing like in other PRs

yadij pushed a commit that referenced this pull request Jan 11, 2026
@timp87 @yadij
Fix typo in LIBMIT_KRB5 variable naming (#2335)
17a8b48 
Discovered while porting Squid v7 to FreeBSD.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rousskov rousskov rousskov left review comments

@kinkie kinkie kinkie approved these changes

@yadij yadij yadij approved these changes

Assignees

No one assigned

Labels

M-merged https://github.com/measurement-factory/anubis#pull-request-labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@timp87 @rousskov @kinkie @yadij @squid-anubis