Skip to content

Fix ./configure EUI check #2338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
timp87 wants to merge 2 commits into from
+2 −1
Closed

Fix ./configure EUI check #2338

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f4ab0b
Fix ./configure eui check
Jan 6, 2026
85c5994
Use arpreq.arp_ha in eui check
Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -992,7 +992,8 @@ include <windows.h>
#include <sys/param.h>
#endif
]])
AC_CHECK_MEMBER([struct arpreq.arp_pa],[],[
AC_CHECK_HEADERS(sys/socket.h)
Copy link
Contributor

@rousskov rousskov Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem here is that HAVE_SYS_SOCKET_H is not defined yet at that point, so it's skipped and the check fails.

I'm not sure how to fix it better like remove #if HAVE_SYS_SOCKET_H condition and let the header be included unconditionally, or include this header into some AC_CHECK_HEADERS a bit above, or something else. So please guide me how you wanted me this to do

I think what you did is the right solution for this PR -- it matches how similar code solves similar problems. There may be a better, more comprehensive solution, but I would place that outside this small/focused PR scope.

This comment answers a question without requesting any changes.

Copy link
Contributor

@yadij yadij Jan 7, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO the checks here should be including our compat/types.h and compat/socket.h instead of the system headers. But that will still need this change first (along with other headers tested). So I am putting that on my TODO list for later, no need to do it here.

Copy link
Contributor

@rousskov rousskov Jan 7, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO the checks here should be including our compat/types.h and compat/socket.h

I am against using compat/ sources in ./configure checks because that would imply that compat/ sources cannot reliably use ./configure results. However, there is now a better place for that discussion. Let's continue this conversation there.

AC_CHECK_MEMBER([struct arpreq.arp_pa.sa_family],[],[
AS_IF([test "x$squid_host_os" != "xmingw" -a "x$squid_host_os" != "xcygwin"],[
AC_MSG_NOTICE([OS support for EUI seems incomplete, disabling it])
enable_eui=no
Expand Down
Loading