-
Notifications
You must be signed in to change notification settings - Fork 603
Maintenance: check for Perl modules #2349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
... used by logic in ./scripts/ directory which may be run during build, testing or release
|
diff of |
rousskov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The proposed checks seem to be unused by any Squid code. Please adjust this PR description to clarify why they should be added.
That is already detailed in the PR description. The code in NB: Some of those scripts are test tools which should be in |
| if test "x$PERL" != x; then | ||
| ax_perl_modules_failed=0 | ||
| for ax_perl_module in ax_perl_modules; do | ||
| AC_MSG_CHECKING(for perl module $ax_perl_module) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use AC_CACHE_CHECK here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tricky to do inside a for loop.
Since this is third-party code import I will try to do as a followup if you want to insist on it.
Was not meaning to approve, there's a comment
... used by logic in ./scripts/ directory which
may be run during build, testing or release