Skip to content

Fix scripts/update-contributors.pl CONTRIBUTORS screening #2356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
squidadm wants to merge 1 commit into
base: v7
Choose a base branch
from
+8 −10
Open

Fix scripts/update-contributors.pl CONTRIBUTORS screening #2356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions scripts/source-maintenance.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -763,15 +763,12 @@ collectAuthors ()
# but do not add committers (--format=' %cn <%ce>').

# add collected new (co-)authors, if any, to CONTRIBUTORS
if ./scripts/update-contributors.pl --quiet < authors.tmp > CONTRIBUTORS.new
then
updateIfChanged CONTRIBUTORS CONTRIBUTORS.new \
"A human PR description should match: $vettedCommitPhraseRegex"
fi
result=$?
./scripts/update-contributors.pl --quiet < authors.tmp > CONTRIBUTORS.new || return
updateIfChanged CONTRIBUTORS CONTRIBUTORS.new \
"A human PR description should match: $vettedCommitPhraseRegex" || return

rm -f authors.tmp
return $result
return 0
}

# Update CONTRIBUTORS content
Expand Down
7 changes: 4 additions & 3 deletions scripts/update-contributors.pl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,9 +134,10 @@ sub worseThan
sub isManuallyExcluded
{
my ($c) = @_;
return true if lc(contributorToString($c)) =~ /squidadm/; # a known bot
return true if lc(contributorToString($c)) =~ /[email protected]/; # a known bot
return false;
my $lowerCasedContributorGist = lc(contributorToString($c));
return 1 if $lowerCasedContributorGist =~ /squidadm/; # a known bot
return 1 if $lowerCasedContributorGist =~ /copilot[@]users[.]noreply[.]github[.]com/; # a known bot
return 0;
}

sub contributorToString
Expand Down
Loading