Skip to content

Conversation

rammba
Copy link
Contributor

@rammba rammba commented Sep 14, 2025

Hello @squidfunk, as a native Serbian speaker and contributor to few open-source projects (eg. official React documentation) I wanted to improve Serbian translations a bit.
Of course, I'm kindly asking previous translators @taocnrut (#835), @majkinetor (#3009) & @stcksmsh (#6999) to take a look and give their opinion about the changes.

Another thing is regarding currently supported Serbo-Croatian (sh) language which is deprecated and unused I suppose. Is there a way to actually add Serbian Latin (as proposed in #1480) instead of that? Maybe I should move this discussion to the issue?

Copy link
Owner

@squidfunk squidfunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR – only minor remarks.

@squidfunk
Copy link
Owner

Another thing is regarding currently supported Serbo-Croatian (sh) language which is deprecated and unused I suppose. Is there a way to actually add Serbian Latin (as proposed in #1480) instead of that? Maybe I should move this discussion to the issue?

Could you please expand on that? Why is it deprecated? Also, we currently only support HTML5 language codes, which the language code mentioned in the issue is not. We might turn the direction around in the future (allow to provide any translations and map back into HTML language), but that's currently not a priority.

@rammba
Copy link
Contributor Author

rammba commented Sep 14, 2025

Could you please expand on that? Why is it deprecated?

It's not actually depracated, but it's an old version of current languages which were used mostly in former Yugoslavia. I'm fine with using it if there is no official code (as mentioned in this comment) for Serbian with Latin script.

@squidfunk
Copy link
Owner

It's not actually depracated, but it's an old version of current languages which were used mostly in former Yugoslavia. I'm fine with using it if there is no official code (as mentioned in #1480 (comment)) for Serbian with Latin script.

I can't really decide that, because I don't speak any kind of Serbian. Maybe the previous translators can comment, so we can reach a decision if that is a sensible path to take. Other than that it's not possible for me/us to judge, and please keep in mind that this might break expectations of users that currently use the code.

Copy link
Owner

@squidfunk squidfunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge now, thanks again!

@squidfunk squidfunk merged commit 97e275c into squidfunk:master Sep 15, 2025
4 checks passed
@rammba rammba deleted the features/serbian-2025-09-14 branch September 15, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants