Skip to content

fix: apply 'patches' after 'buildFromSdist' #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: apply 'patches' after 'buildFromSdist' #291

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0e64b33
fix: apply 'patches' after 'buildFromSdist'
srid Apr 2, 2024
508d43e
Merge branch 'master' into buildFromSdist-patches
srid Apr 3, 2024
ea1baec
Merge branch 'master' into buildFromSdist-patches
srid Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions nix/modules/project/settings/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,8 @@ in
# In future, we can refactor this as part of https://github.com/srid/haskell-flake/issues/285
# NOTE: removeReferencesTo must apply *before* buildFromSdist, because the
# later appears it fuck up the former otherwise.
impl = lib.attrsets.removeAttrs cfg.impl [ "buildFromSdist" "removeReferencesTo" ];
fns = lib.attrValues impl ++ [ cfg.impl.buildFromSdist cfg.impl.removeReferencesTo ];
impl = lib.attrsets.removeAttrs cfg.impl [ "buildFromSdist" "removeReferencesTo" "patches" ];
fns = lib.attrValues impl ++ [ cfg.impl.buildFromSdist cfg.impl.removeReferencesTo cfg.impl.patches ];
in
lib.pipe super.${name} (
# TODO: Do we care about the *order* of overrides?
Expand Down