Conversation
This page biases towards supervisors reading it, which is fine, however may make it harder to interpret for competitors. This change calls out upfront what a competitor should do to get access in order to avoid confusion.
|
The last sentence on Line 50 doesn't quite read right, think there needs to be an are in there |
Nice! e55c474 Meta: not sure if you're aware, but it's possible to comment on files in the diff as well as lines. Doing that means we get an inline conversation thread which can be resolved in the usual way, albeit at the top of the file rather than on a line of the file. It's handy for things like this which are outside the diff.
|
Wasn't aware of that no, Still learning my way around GitHub. At some point I should probably clone some of the SR repos if only to be better able to review PRs |
ShadowLord2005
left a comment
ShadowLord2005
left a comment
There was a problem hiding this comment.
Everything looks good to me now.
2 participants
Suggest review by commit.