Skip to content

Commit ac29087

Browse files
FabianEckermanncodebot
authored andcommitted
cu_cp,f1ap: align ue context release procedure to other ue context procedures
1 parent 5990f1b commit ac29087

File tree

3 files changed

+10
-13
lines changed

3 files changed

+10
-13
lines changed

lib/f1ap/cu_cp/f1ap_cu_impl.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ async_task<ue_index_t> f1ap_cu_impl::handle_ue_context_release_command(const f1a
108108
});
109109
}
110110

111-
return launch_async<ue_context_release_procedure>(msg, ue_ctxt_list[msg.ue_index], tx_pdu_notifier, cfg.proc_timeout);
111+
return launch_async<ue_context_release_procedure>(cfg, msg, ue_ctxt_list[msg.ue_index], tx_pdu_notifier);
112112
}
113113

114114
async_task<f1ap_ue_context_modification_response>

lib/f1ap/cu_cp/procedures/ue_context_release_procedure.cpp

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,11 @@ using namespace srsran;
1818
using namespace srsran::srs_cu_cp;
1919
using namespace asn1::f1ap;
2020

21-
ue_context_release_procedure::ue_context_release_procedure(const f1ap_ue_context_release_command& cmd_,
21+
ue_context_release_procedure::ue_context_release_procedure(const f1ap_configuration& f1ap_cfg_,
22+
const f1ap_ue_context_release_command& cmd_,
2223
f1ap_ue_context& ue_ctxt_,
23-
f1ap_message_notifier& f1ap_notif_,
24-
std::chrono::milliseconds proc_timeout_) :
25-
ue_ctxt(ue_ctxt_),
26-
f1ap_notifier(f1ap_notif_),
27-
proc_timeout(proc_timeout_),
28-
logger(srslog::fetch_basic_logger("CU-CP-F1"))
24+
f1ap_message_notifier& f1ap_notif_) :
25+
f1ap_cfg(f1ap_cfg_), ue_ctxt(ue_ctxt_), f1ap_notifier(f1ap_notif_), logger(srslog::fetch_basic_logger("CU-CP-F1"))
2926
{
3027
command->gnb_cu_ue_f1ap_id = gnb_cu_ue_f1ap_id_to_uint(ue_ctxt.ue_ids.cu_ue_f1ap_id);
3128
command->gnb_du_ue_f1ap_id = gnb_du_ue_f1ap_id_to_uint(ue_ctxt.ue_ids.du_ue_f1ap_id);
@@ -47,7 +44,7 @@ void ue_context_release_procedure::operator()(coro_context<async_task<ue_index_t
4744

4845
logger.debug("{}: Procedure started...", f1ap_ue_log_prefix{ue_ctxt.ue_ids, name()});
4946

50-
transaction_sink.subscribe_to(ue_ctxt.ev_mng.context_release_complete, proc_timeout);
47+
transaction_sink.subscribe_to(ue_ctxt.ev_mng.context_release_complete, f1ap_cfg.proc_timeout);
5148

5249
ue_ctxt.marked_for_release = true;
5350

lib/f1ap/cu_cp/procedures/ue_context_release_procedure.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,10 @@ namespace srs_cu_cp {
2424
class ue_context_release_procedure
2525
{
2626
public:
27-
ue_context_release_procedure(const f1ap_ue_context_release_command& cmd_,
27+
ue_context_release_procedure(const f1ap_configuration& f1ap_cfg_,
28+
const f1ap_ue_context_release_command& cmd_,
2829
f1ap_ue_context& ue_ctxt_,
29-
f1ap_message_notifier& f1ap_notif_,
30-
std::chrono::milliseconds proc_timeout);
30+
f1ap_message_notifier& f1ap_notif_);
3131

3232
void operator()(coro_context<async_task<ue_index_t>>& ctx);
3333

@@ -40,10 +40,10 @@ class ue_context_release_procedure
4040
/// Creates procedure result to send back to procedure caller.
4141
ue_index_t create_ue_context_release_complete();
4242

43+
const f1ap_configuration& f1ap_cfg;
4344
f1ap_ue_context& ue_ctxt;
4445
asn1::f1ap::ue_context_release_cmd_s command;
4546
f1ap_message_notifier& f1ap_notifier;
46-
const std::chrono::milliseconds proc_timeout;
4747
srslog::basic_logger& logger;
4848

4949
protocol_transaction_outcome_observer<asn1::f1ap::ue_context_release_complete_s> transaction_sink;

0 commit comments

Comments
 (0)