Adds support for MSSQL and Azure SQL #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds MSSQL and Azure SQL database support, including necessary dependencies and connection logic. It includes a version bump to 1.2.3. The changes implement the `executeMSSQLQuery` function to handle query execution for MSSQL and Azure SQL databases. It constructs the connection configuration, executes the query, and formats the result into a standard `QueryResult` object. Also, the `executeQuery` function is updated to route MSSQL/Azure SQL connections to the new handler. Updates query execution logic to incorporate `TOP` clause for limiting number of rows fetched from MSSQL, Azure SQL, and SQL Server databases to address the missing limit clause which could cause a timeout. Also, includes better logging of errors to help diagnose issues. These modifications allows the application to connect to and query MSSQL and Azure SQL databases directly, improving its database compatibility. Fixes: properly handle errors when listing tables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds MSSQL and Azure SQL database support, including necessary dependencies and connection logic.
The changes implement the
executeMSSQLQueryfunction to handle query execution for MSSQL and Azure SQL databases. It constructs the connection configuration, executes the query, and formats the result into a standardQueryResultobject. Also, theexecuteQueryfunction is updated to route MSSQL/Azure SQL connections to the new handler.Updates query execution logic to incorporate
TOPclause for limiting number of rows fetched from MSSQL, Azure SQL, and SQL Server databases to address the missing limit clause which could cause a timeout. Also, includes better logging of errors to help diagnose issues.These modifications allows the application to connect to and query MSSQL and Azure SQL databases directly, improving its database compatibility.
I also added error handling and tested it with my azure sql Databases.