Case-insensitive Replay-Nonce headers #884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I can confirm that running this branch with the config in #883 does indeed eliminate the first |
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where getssl fails to extract the Replay-Nonce header when ACME servers (specifically Sectigo) send it in lowercase. The fix makes the header matching case-insensitive, which is the correct behavior according to HTTP standards (RFC 7230).
Changes:
- Added
-iflag to two grep commands that extract the Replay-Nonce header from ACME server responses
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split off from #859; I believe this is a separate bug which still exists:
It appears that further down it does use
grep -i, so in effect it's just causing an initial "bad nonce" and will succeed on retry, but we may as well fix the first attempt.