KeyboardApi methods return Result<T> instead of Option<T>#3
Merged
srwi merged 1 commit intosrwi:masterfrom Oct 11, 2025
Merged
Conversation
- Introduce a unified `Error` enum. - Update all `KeyboardApi` methods to return `Result<T>`. - Implement `From<Error>` for `pyo3::PyErr` to support Python bindings. BREAKING CHANGE: `KeyboardApi` methods now return `Result<T>` instead of `Option<T>`
Owner
|
Thank you for the PR! I haven't had the time to look into it. Will do so in the coming days! |
Contributor
Author
|
Thank you, and no worries! I know it looks like a lot, but the bulk of it is simply replacing |
Owner
|
Finally got to have a closer look. I like the changes. Thanks again for the contribution! 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Errorenum.KeyboardApimethods to returnResult<T>.From<Error>forpyo3::PyErrto support Python bindings.BREAKING CHANGE:
KeyboardApimethods now returnResult<T>instead ofOption<T>