fix: Support top level style tag.

[yeldiRium]

I have a working implementation that supports top level style tags and is tested. It is based on my comments in #34.

This feels a bit hacky, since I'm circumventing the defs handling. @srwiley what do you think?

[goloroden]

Hey @srwiley 👋

Any chance that this gets merged in the near future?

[srwiley]

Thanks yeldiRium and goloroden for improving oksvg! Sorry this took so long to get to.

[goloroden]

@srwiley Just to get this right – all the work was done by @yeldiRium, so he's the one who should get the credit 🦄

(I was only asking because I was waiting for the merge 😉)

[srwiley]

Hey Hannes and Golo, Yes, thanks to both of you. I realize Hannes did an elegant job coding the pull request. But I doubt either Hannes or myself do not appreciate the contributions of third party testers and their feedback. But speaking of, can I burden you guys with looking at pull request #41 in oksvg? This may be redundant, but the remaining issue he mentioned about a grad stop seems like his pull request is a bit excessive for the problem. Your heads are more wrapped about this area than mine at the moment, so let me know what you think if you have the time.

…

-Steve

On Fri, Aug 12, 2022 at 1:32 AM Hannes Leutloff ***@***.***> wrote: I have a working implementation that supports top level style tags and is tested. It is based on my comments in #34 <#34>. This feels a bit hacky, since I'm circumventing the defs handling. @srwiley <https://github.com/srwiley> what do you think? ------------------------------ You can view, comment on, or merge this pull request online at: #40 Commit Summary - dcae0f7 <dcae0f7> fix: Allow top level style tag. - fca98ed <fca98ed> fix: Use new style draw func to handle top level styles. File Changes (3 files <https://github.com/srwiley/oksvg/pull/40/files>) - *M* draw.go <https://github.com/srwiley/oksvg/pull/40/files#diff-21a3458a0fc6d74672243fd11ca579bedb273a586c5cfe74f61e82b265bf1130> (5) - *M* svgdraw_test.go <https://github.com/srwiley/oksvg/pull/40/files#diff-c90f04f34a88370f474c1ea11f77bd522dc75db93c3b0efd2a556a6669770ace> (8) - *A* testdata/TopLevelStyle.svg <https://github.com/srwiley/oksvg/pull/40/files#diff-5dcb08baa65baaf9a5046548587a8cb18e6a2a776a9985e2c67e61ad3da5632d> (12) Patch Links: - https://github.com/srwiley/oksvg/pull/40.patch - https://github.com/srwiley/oksvg/pull/40.diff — Reply to this email directly, view it on GitHub <#40>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC4VOBYOR2X5523LMONMGWLVYYDYHANCNFSM56K4DXVQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>