Do not login or push to dockerhub if secrets not available in job#995
Merged
kyungeonchoi merged 1 commit intodevelopfrom Mar 18, 2025
Merged
Do not login or push to dockerhub if secrets not available in job#995kyungeonchoi merged 1 commit intodevelopfrom
kyungeonchoi merged 1 commit intodevelopfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's important that dependabot be able to build docker images to test that the updated
poetry.lockfiles actually work in the container build process. The current setup requires that the Docker Hub secrets be present in the CI job or else things will fail, and dependabot does not have access to these. Use a conditional to avoid pushing the images, and just check we can build them.