Closed
Conversation
cc943af to
1af3f1d
Compare
for more information, see https://pre-commit.ci
…rviceX_frontend into feat/register-backend
Collaborator
Author
|
Decided to not go this route - and move towards dealing with local as a standalone package. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code was designed to enable a local version of SX to run, in process, to help wtih debugging and development.
Endpointto track a special adaptor.ServiceXClientproperly creates a specialized client when requested., and one for theminiofor_transform.ServiceXAdaptorandMinioAdaptoras a protocal.Notes:
pydanticcan't seem to deal with duck typing Protocals, soobjectis getting used.protocoltotally - especially if thepydanticproblem can't be solved. Or make them sub-classes of a ABC.