Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #702 +/- ##
==========================================
+ Coverage 98.35% 98.38% +0.03%
==========================================
Files 30 31 +1
Lines 2191 2234 +43
==========================================
+ Hits 2155 2198 +43
Misses 36 36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BenGalewsky
reviewed
Jan 21, 2026
BenGalewsky
reviewed
Jan 21, 2026
Contributor
|
hey, how about some unit tests? |
BenGalewsky
requested changes
Feb 6, 2026
Contributor
BenGalewsky
left a comment
BenGalewsky
left a comment
There was a problem hiding this comment.
These changes need unit tests
…into 685-add-servicex-check-cli-command
…into 685-add-servicex-check-cli-command
BenGalewsky
approved these changes
Mar 30, 2026
Contributor
BenGalewsky
left a comment
BenGalewsky
left a comment
There was a problem hiding this comment.
Looks good. Please fix the merge conflicts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checks all endpoints in
servicex.yamland verifies the connection with token.