Add matcher property to actions and pass search to handler function#56
Open
simonc wants to merge 1 commit intossleptsov:mainfrom
Open
Add matcher property to actions and pass search to handler function#56simonc wants to merge 1 commit intossleptsov:mainfrom
simonc wants to merge 1 commit intossleptsov:mainfrom
Conversation
matcher property to actions that allows for dynamic matching of actions. The matcher property can be a function that receives the search string and returns a boolean indicating whether the action should be executed.|
I think this would be a great addition! Unfortunately, this repo seems a bit abandoned, so I would suggest creating the PR on this fork https://github.com/KonnorRogers/konnors-ninja-keys created by @KonnorRogers, which seems to be pretty active. |
Author
|
Hi @aMaze613. Thanks for letting me know! 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a
matcherproperty to actions that allows for dynamic matching of actions. Thematcherproperty can be a function that receives the search string and returns a boolean indicating whether the action should be executed.When the
matcherfunction is defined, the search will only use it and not match on the title or keywords of the action.It also passes the search string to the
handlerfunction, so that the handler can use it to perform actions.Both additions allow actions based on the search string, like jumping to resources (user, project, …) pages. Coupled with semantic object IDs this can open the gate to a lot of possibilities.