-
-
Notifications
You must be signed in to change notification settings - Fork 72
Raise import limits #1035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sspanak
wants to merge
3
commits into
master
Choose a base branch
from
raise-import-limits
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Raise import limits #1035
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 34 additions & 0 deletions
34
...ain/java/io/github/sspanak/tt9/preferences/screens/languages/SwitchRaiseImportLimits.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| package io.github.sspanak.tt9.preferences.screens.languages; | ||
|
|
||
| import android.content.Context; | ||
| import android.util.AttributeSet; | ||
|
|
||
| import androidx.annotation.NonNull; | ||
| import androidx.annotation.Nullable; | ||
| import androidx.preference.SwitchPreferenceCompat; | ||
|
|
||
| import io.github.sspanak.tt9.R; | ||
| import io.github.sspanak.tt9.preferences.settings.SettingsAddedWords; | ||
|
|
||
| public class SwitchRaiseImportLimits extends SwitchPreferenceCompat { | ||
| public static final String NAME = "pref_raise_custom_words_import_limits"; | ||
| public static final boolean DEFAULT = false; | ||
|
|
||
| public SwitchRaiseImportLimits(@NonNull Context context, @Nullable AttributeSet attrs, int defStyleAttr, int defStyleRes) { super(context, attrs, defStyleAttr, defStyleRes); init(context); } | ||
| public SwitchRaiseImportLimits(@NonNull Context context, @Nullable AttributeSet attrs, int defStyleAttr) { super(context, attrs, defStyleAttr); init(context); } | ||
| public SwitchRaiseImportLimits(@NonNull Context context, @Nullable AttributeSet attrs) { super(context, attrs); init(context); } | ||
| public SwitchRaiseImportLimits(@NonNull Context context) { super(context); init(context); } | ||
|
|
||
| private void init(@NonNull Context context) { | ||
| setKey(NAME); | ||
| setDefaultValue(DEFAULT); | ||
| setTitle(R.string.dictionary_import_raise_import_limits); | ||
| setSummary(context.getString( | ||
| R.string.dictionary_import_raise_import_limits_summary, | ||
| SettingsAddedWords.IMPORT_DEFAULT_MAX_FILE_LINES, | ||
| SettingsAddedWords.IMPORT_RAISED_MAX_FILE_LINES, | ||
| SettingsAddedWords.IMPORT_DEFAULT_MAX_WORDS, | ||
| SettingsAddedWords.IMPORT_RAISED_MAX_WORDS | ||
| )); | ||
| } | ||
| } |
33 changes: 33 additions & 0 deletions
33
app/src/main/java/io/github/sspanak/tt9/preferences/settings/SettingsAddedWords.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| package io.github.sspanak.tt9.preferences.settings; | ||
|
|
||
| import android.content.Context; | ||
|
|
||
| import io.github.sspanak.tt9.preferences.screens.languages.SwitchAddWordsWithoutConfirmation; | ||
| import io.github.sspanak.tt9.preferences.screens.languages.SwitchRaiseImportLimits; | ||
|
|
||
| public class SettingsAddedWords extends BaseSettings { | ||
| public final static int IMPORT_DEFAULT_MAX_FILE_LINES = 250; | ||
| public final static int IMPORT_DEFAULT_MAX_WORDS = 1000; | ||
| public final static int IMPORT_RAISED_MAX_FILE_LINES = 10_000; | ||
| public final static int IMPORT_RAISED_MAX_WORDS = 100_000; | ||
|
|
||
| SettingsAddedWords(Context context) { | ||
| super(context); | ||
| } | ||
|
|
||
| public boolean getAddWordsNoConfirmation() { | ||
| return prefs.getBoolean(SwitchAddWordsWithoutConfirmation.NAME, false); | ||
| } | ||
|
|
||
| public boolean getRaiseImportLimits() { | ||
| return prefs.getBoolean(SwitchRaiseImportLimits.NAME, SwitchRaiseImportLimits.DEFAULT); | ||
| } | ||
|
|
||
| public int getImportWordsMaxFileLines() { | ||
| return getRaiseImportLimits() ? IMPORT_RAISED_MAX_FILE_LINES : IMPORT_DEFAULT_MAX_FILE_LINES; | ||
| } | ||
|
|
||
| public int getImportWordsMaxWords() { | ||
| return getRaiseImportLimits() ? IMPORT_RAISED_MAX_WORDS : IMPORT_DEFAULT_MAX_WORDS; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.