Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ tasks.register('buildDictionaryDownloads') {
tasks.register('copyDownloadsToAssets', Copy) {
from DICTIONARIES_DOWNLOAD_DIR
include '**/*.zip'
// Keep Latin as a downloadable add-on language; do not bundle it in the full APK.
exclude 'la-utf8.zip'
Comment on lines +51 to +52
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't do this. The full version is intended to come with all languages. It does not have the Internet permission and it can not download anything.

Suggested change
// Keep Latin as a downloadable add-on language; do not bundle it in the full APK.
exclude 'la-utf8.zip'

into DICTIONARIES_OUTPUT_DIR
dependsOn buildDictionaryDownloads
mustRunAfter buildDictionaryDownloads
Expand Down
15 changes: 15 additions & 0 deletions app/languages/definitions/Latin.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
locale: la
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TT9 does not support 2-letter locales, except for English.

Suggested change
locale: la
locale: la-VA

dictionaryFile: la-utf8.txt
name: Lingua Latina
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Java should be able to generate a proper name. Let's specify it manually only if it is unclear, or if it fails.

Suggested change
name: Lingua Latina

iconABC: ic_lang_latin
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iconT9 is mandatory. Please add a new entry to scripts/iconz/generate-all.sh, generate the icons and put them in the res directory.

StatusIcon.java also needs to be updated, but it will happen automatically, when you build the project with Android Studio, gradle, or whatever you are using. Just don't forget to include it in the pull request.

layout:
- [SPECIAL] # 0
- [PUNCTUATION] # 1
- [a, ā, b, c] # 2
- [d, e, ē, f] # 3
- [g, h, i, ī] # 4
- [j, k, l] # 5
- [m, n, o, ō] # 6
- [p, q, r, s] # 7
- [t, u, ū, v] # 8
- [w, x, y, ȳ, z] # 9
Loading