Draft
Conversation
sspanak
added
help wanted
sspanak
commented
Jul 1, 2025
| public static boolean isEnglish(Language language) { return language != null && language.getLocale().equals(Locale.ENGLISH); } | ||
| public static boolean isChinese(Language language) { return isChineseBopomofo(language) || isChinesePinyin(language); } | ||
| public static boolean isChineseBopomofo(Language language) { return language != null && language.getId() == 774426; } | ||
| public static boolean isChineseBopomofo(Language language) { return language != null && (language.getId() == 774426 || language.getId() == 368922); } |
Owner
Author
There was a problem hiding this comment.
Remove this hack in the final release. 368922 is "large", 774426 is "small".
| @@ -0,0 +1,58 @@ | |||
| locale: zh-HK | |||
Owner
Author
There was a problem hiding this comment.
Keep either the small one or this one in the final release. Also, the locale must be "zh-TW".
sspanak
force-pushed
the
bopomofo-dictionary
branch
from
64b50e3 to
df09ebb
Compare
sspanak
force-pushed
the
bopomofo-dictionary
branch
from
df09ebb to
7f31d58
Compare
sspanak
force-pushed
the
bopomofo-dictionary
branch
from
7f31d58 to
6689df3
Compare
sspanak
force-pushed
the
bopomofo-dictionary
branch
from
6689df3 to
aa8ffe6
Compare
sspanak
force-pushed
the
bopomofo-dictionary
branch
from
aa8ffe6 to
edba9d7
Compare
sspanak
force-pushed
the
bopomofo-dictionary
branch
4 times, most recently
from
dd3e965 to
e50cd61
Compare
sspanak
force-pushed
the
bopomofo-dictionary
branch
2 times, most recently
from
0bf80c0 to
2b6aec3
Compare
Owner
Author
|
Also, must update the status icons and add .zip files. |
sspanak
force-pushed
the
bopomofo-dictionary
branch
from
a045da0 to
c0a1f75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From technical perspective Bopomofo is completed. However, I need a confirmation from a native Chinese speaker that it actually works and whether to use the "small" or the "large" dictionary. More details and an APK for testing are available in #722.