feature: add support for JSONC in user theme files and add test coverage for theme loading functionality (resolves #4927) #5134
+234
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… opencode.jsonc is handled.
…leSpecialFeatures), add a JSDoc comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4927.
This PR improves consistency and adherence to the principle of least surprise by giving users' custom theme files the same treatment as
opencode.json/opencode.jsoncand permitting them to contain either plain JSON or JSONC with the option of trailing commas. Similarly to howopencode.jsonis handled, user themes are now parsed as JSONC regardless of the physical file extension.In addition to improving adherence to the principle of least surprise, this improves UX when working on adjusting one's custom theme files, as it can be very convenient to be able to comment lines in a theme file in in and out while adjusting its aesthetics.
In addition, this PR adds tests for the theme loading functionality, which had no test coverage prior to this PR.