Proposal to fix incomplete StockQuote and StockStats using API v7.#182
Open
WIM-TRD wants to merge 2 commits intosstrickx:developfrom
Open
Proposal to fix incomplete StockQuote and StockStats using API v7.#182WIM-TRD wants to merge 2 commits intosstrickx:developfrom
WIM-TRD wants to merge 2 commits intosstrickx:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found this issue when trying to retrieve EBITDA data from stock.
Relates to ticket: #153
In current version of the code when requesting a quote from the API (v7) the response is not fully "complete" towards the wanted variables in StockQuote and Stats.
By using "fields" as a parameter we can extract more information regarding the stock.
Thank you for considering the proposal and please leave feedback if merge not suitable.
(No regression test was done)