Refactor/excessive params list#217
Open
VictorM-Coder wants to merge 8 commits intosstrickx:developfrom
Open
Conversation
Stock class refactored
refactor GodClass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolution of Issue #216
Taking the issue for code quality improvement of the system as a reference, focusing on addressing code smells, we performed code refactoring for the code smell Excessive Parameter List in HistoricalQuote and StockDividend classes using the builder pattern as refactoring method
Code Analysis
After performing the necessary refactoring, we ran PMD once again following the same directives indicated in the issue and found the following results (indicating that we were able to address the aforementioned code smells):]
Notion