Skip to content

Fix missed override in statnull.h #1227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feldergast merged 1 commit into from
Mar 4, 2025
Merged

Fix missed override in statnull.h #1227

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/sst/core/statapi/statnull.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ class NullStatisticBase<T, true> : public Statistic<T>

void addData_impl_Ntimes(uint64_t UNUSED(N), T UNUSED(data)) override {}

virtual const std::string& getStatTypeName() const { return stat_type_; }
virtual const std::string& getStatTypeName() const override { return stat_type_; }

private:
inline static const std::string stat_type_ = "NULL";
Expand All @@ -70,7 +70,7 @@ class NullStatisticBase<std::tuple<Args...>, false> : public Statistic<std::tupl

void addData_impl_Ntimes(uint64_t UNUSED(N), Args... UNUSED(data)) override {}

virtual const std::string& getStatTypeName() const { return stat_type_; }
virtual const std::string& getStatTypeName() const override { return stat_type_; }

private:
inline static const std::string stat_type_ = "NULL";
Expand All @@ -91,7 +91,7 @@ class NullStatisticBase<T, false> : public Statistic<T>
void addData_impl_Ntimes(uint64_t UNUSED(N), T&& UNUSED(data)) override {}
void addData_impl_Ntimes(uint64_t UNUSED(N), const T& UNUSED(data)) override {}

virtual const std::string& getStatTypeName() const { return stat_type_; }
virtual const std::string& getStatTypeName() const override { return stat_type_; }

private:
inline static const std::string stat_type_ = "NULL";
Expand Down Expand Up @@ -164,7 +164,7 @@ class NullStatistic<void> : public Statistic<void>

virtual std::string getELIName() const override { return "sst.NullStatistic"; }

virtual const std::string& getStatTypeName() const { return stat_type_; }
virtual const std::string& getStatTypeName() const override { return stat_type_; }

private:
inline static const std::string stat_type_ = "NULL";
Expand Down
Loading