Adding global statistics and statistics groups for JSON reader and writer#1232
Closed
jleidel wants to merge 2 commits intosstsimulator:develfrom
Closed
Adding global statistics and statistics groups for JSON reader and writer#1232jleidel wants to merge 2 commits intosstsimulator:develfrom
jleidel wants to merge 2 commits intosstsimulator:develfrom
Conversation
github-actions
bot
added
AT: WIP
|
CLANG-FORMAT TEST - PASSED |
github-actions
bot
added
AT: WIP
|
CMAKE-FORMAT TEST - PASSED |
Contributor
|
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
feldergast
requested changes
Mar 5, 2025
Contributor
feldergast
left a comment
feldergast
left a comment
There was a problem hiding this comment.
At quick glance, these changes look good. But, we'll need to make sure the new functionality is being tested. Probably the easiest way to add them is to add them to the config_input_output test suite. To do that, add a stat to sst/core/testElements/message_mesh/enclosingComponent.{h,cc} and enable it in the input file. This should test both stat output and input for json.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding global statistics and statistics groups for JSON reader and writer. This targets Issue #1066. Currently passes all the standard
sst-coretests.