Skip to content

Add include guard to sst_config.h#1269

Merged
gvoskuilen merged 1 commit intosstsimulator:develfrom
gvoskuilen:config_guard
Mar 21, 2025
Merged

Add include guard to sst_config.h#1269
gvoskuilen merged 1 commit intosstsimulator:develfrom
gvoskuilen:config_guard

Conversation

@gvoskuilen
Copy link
Contributor

@gvoskuilen gvoskuilen commented Mar 20, 2025

Simplifies use of the generated sst_config.h by giving it an include guard.

@gvoskuilen gvoskuilen requested a review from feldergast March 20, 2025 19:12
@gvoskuilen gvoskuilen self-assigned this Mar 20, 2025
@github-actions github-actions bot added AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) AT: CMAKE-FORMAT PASS AT: CLANG-FORMAT PASS and removed AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) labels Mar 20, 2025
@github-actions
Copy link

github-actions bot commented Mar 20, 2025

CLANG-FORMAT TEST - PASSED

@github-actions
Copy link

github-actions bot commented Mar 20, 2025

CMAKE-FORMAT TEST - PASSED

@sst-autotester
Copy link
Contributor

sst-autotester commented Mar 20, 2025

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request.

@sst-autotester
Copy link
Contributor

sst-autotester commented Mar 20, 2025

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements

  • Build Num: 1886
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MR-2

  • Build Num: 1842
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MT-2

  • Build Num: 1841
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-macro_withsstcore

  • Build Num: 828
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core_Make-Dist

  • Build Num: 681
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_Clang-Format_sst-core

  • Build Num: 635
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements

  • Build Num: 409
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-macro_withsstcore

  • Build Num: 253
  • Status: STARTED

Using Repos:

Repo: CORE (gvoskuilen/sst-core)
  • Branch: config_guard
  • SHA: ca05802
  • Mode: TEST_REPO
Repo: SQE (sstsimulator/sst-sqe)
  • Branch: devel
  • SHA: fc3830fbe74ce06cebb6b6838c78777a6855707a
  • Mode: SUPPORT_REPO
Repo: ELEMENTS (sstsimulator/sst-elements)
  • Branch: devel
  • SHA: 6e06d3746b6ab34d13b33fcf5a7ad2792da22382
  • Mode: SUPPORT_REPO
Repo: MACRO (sstsimulator/sst-macro)
  • Branch: devel
  • SHA: 42e85e1689d473c65fdbcc008ce57fd53fe80865
  • Mode: SUPPORT_REPO

Pull Request Author: gvoskuilen

@leekillough
Copy link
Contributor

leekillough commented Mar 20, 2025

LGTM

@sst-autotester
Copy link
Contributor

sst-autotester commented Mar 20, 2025

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements

  • Build Num: 1886
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MR-2

  • Build Num: 1842
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MT-2

  • Build Num: 1841
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-macro_withsstcore

  • Build Num: 828
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core_Make-Dist

  • Build Num: 681
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_Clang-Format_sst-core

  • Build Num: 635
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements

  • Build Num: 409
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-macro_withsstcore

  • Build Num: 253
  • Status: PASSED

@sst-autotester
Copy link
Contributor

sst-autotester commented Mar 20, 2025

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

@sst-autotester
Copy link
Contributor

sst-autotester commented Mar 20, 2025

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@sst-autotester
Copy link
Contributor

sst-autotester commented Mar 21, 2025

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ jmlapre ]!

@sst-autotester
Copy link
Contributor

sst-autotester commented Mar 21, 2025

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

@jmlapre
Copy link
Member

jmlapre commented Mar 21, 2025

@gvoskuilen We should probably do this for elements as well...

@sst-autotester
Copy link
Contributor

sst-autotester commented Mar 21, 2025

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

2 similar comments
@sst-autotester
Copy link
Contributor

sst-autotester commented Mar 21, 2025

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

@sst-autotester
Copy link
Contributor

sst-autotester commented Mar 21, 2025

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

@gvoskuilen gvoskuilen removed the request for review from feldergast March 21, 2025 16:02
jmlapre added a commit to jmlapre/sst-elements that referenced this pull request Mar 21, 2025
@jmlapre
Add include guard to sst_element_config.h
c00f4ee 
Similar to sstsimulator/sst-core#1269
@jmlapre jmlapre mentioned this pull request Mar 21, 2025
Merged
@sst-autotester
Copy link
Contributor

sst-autotester commented Mar 21, 2025

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

@gvoskuilen gvoskuilen merged commit 6488a8c into sstsimulator:devel Mar 21, 2025
7 checks passed
gvoskuilen pushed a commit to sstsimulator/sst-elements that referenced this pull request Mar 21, 2025
@jmlapre
Add include guard to sst_element_config.h (#2472)
ed29dd9 
Similar to sstsimulator/sst-core#1269
bliu1013 pushed a commit to bliu1013/sst-elements that referenced this pull request Apr 9, 2025
@jmlapre @bliu1013
Add include guard to sst_element_config.h (sstsimulator#2472)
9ebe864 
Similar to sstsimulator/sst-core#1269
@berquist berquist added this to the SST V15.0.0 milestone Apr 14, 2025
hughes-c pushed a commit to hughes-c/sst-elements that referenced this pull request Jun 30, 2025
@jmlapre @hughes-c
Add include guard to sst_element_config.h (sstsimulator#2472)
1e0e708 
Similar to sstsimulator/sst-core#1269
@gvoskuilen gvoskuilen deleted the config_guard branch January 12, 2026 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmlapre jmlapre jmlapre approved these changes

Assignees

@gvoskuilen gvoskuilen

Labels

AT: CLANG-FORMAT PASS AT: CMAKE-FORMAT PASS Enhancement SST-BuildSystem

Projects

None yet

Milestone

SST V15.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@gvoskuilen @sst-autotester @leekillough @jmlapre @berquist