Add support for shutdown from interactive console by skuntz · Pull Request #1311 · sstsimulator/sst-core

skuntz · 2025-04-22T20:54:01Z

Experimental - not required for 15.0 release

Add support to interactiveConsole for an interactiveShutdown function that exits the interactive console and does a clean shutdown of the simulation. This is modeled after the signalShutdown function in simulation.cc and tested in the simpleDebug prototype.

Instructions for Issuing a Pull Request to sst-core

1 - Verify that the Pull Request is targeted to the devel branch of sstsimulator/sst-core

2 - Verify that Source branch is up to date with the devel branch of sst-core

3 - After submitting your Pull Request:

Automatic Testing will commence in a short while
- Pull Requests will be tested with the devel branches of the sst-elements and sst-sqe repositories
  - These branches are syncronized with the devel branch of sst-core. This is why is it important to keep your source branch up to date.
- If testing passes, the SST Core developers will review your changes and merge them or contact you for more information
  - Pull Requests from forks will not be automatically tested until the code is inspected.
  - Pull Requests from forks will not be automatically merged into the devel branch.
- If testing fails, You will be notified of the test results.
  - The Pull Request will be retested on a regular basis - Changes to the source branch can be made to correct problems

github-actions · 2025-04-22T20:54:23Z

CLANG-FORMAT TEST - PASSED

github-actions · 2025-04-22T20:54:26Z

CMAKE-FORMAT TEST - PASSED

github-actions · 2025-05-12T16:37:19Z

CLANG-FORMAT TEST - FAILED (on last commit):
Run > ./scripts/clang-format-test.sh using clang-format v20 to check formatting

github-actions · 2025-05-12T16:37:22Z

CMAKE-FORMAT TEST - PASSED

sst-autotester · 2025-05-12T16:57:01Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

github-actions · 2025-05-27T13:29:57Z

CLANG-FORMAT TEST - FAILED (on last commit):
Run > ./scripts/clang-format-test.sh using clang-format v20 to check formatting

github-actions · 2025-05-27T13:30:01Z

CMAKE-FORMAT TEST - PASSED

github-actions · 2025-05-27T13:39:16Z

CLANG-FORMAT TEST - PASSED

github-actions · 2025-05-27T13:39:19Z

CMAKE-FORMAT TEST - PASSED

sst-autotester · 2025-05-27T13:51:00Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

src/sst/core/interactiveConsole.cc

github-actions · 2025-05-28T14:43:19Z

CLANG-FORMAT TEST - PASSED

github-actions · 2025-05-28T14:43:24Z

CMAKE-FORMAT TEST - PASSED

sst-autotester · 2025-05-28T14:51:27Z

Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; this inspection will remain valid until a new commit to source branch is performed.

sst-autotester · 2025-05-28T14:54:35Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements

Build Num: 2071
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MR-2

Build Num: 2027
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MT-2

Build Num: 2026
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core_Make-Dist

Build Num: 803
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements

Build Num: 582
Status: STARTED

Using Repos:

Repo: CORE (skuntz/sst-core)

Repo: SQE (sstsimulator/sst-sqe)

Repo: ELEMENTS (sstsimulator/sst-elements)

Repo: MACRO (sstsimulator/sst-macro)

Pull Request Author: skuntz

sst-autotester · 2025-05-28T15:49:36Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements

Build Num: 2071
Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MR-2

Build Num: 2027
Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MT-2

Build Num: 2026
Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core_Make-Dist

Build Num: 803
Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements

Build Num: 582
Status: PASSED

sst-autotester · 2025-05-28T15:49:54Z

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ feldergast ]!

sst-autotester · 2025-05-28T15:50:01Z

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

Major Changes: - config.h, config.cc Add support for interactive realtime action, sst.rt.interactive (sstsimulator#1266) Add checkpoint-enable flag to enable checkpointing in interactive console. Make sst.rt.simpledebug the default for interactive console and only use --interactive-console to specify a custom IC File replay option ( --replay ) - from_string.h: Full precision printing of float types. Scientific notation when value is greated than 10**6 or less than 10**-6 - impl/interactive/Makefile.inc Included cmdLineEditor files for build - impl/interactive/cmdLineEditor.h, impl/interactive/cmdLineEditor.cc In-line command editing support - impl/interactive/simpleDebug.h, impl/interactive/simpleDebug.cc Shutdown support (sstsimulator#1311) Watchpoint support Add checkpoint-enabled flag to enable in interactive console. Make sst.rtl.simpledebug the default of interactive console. Only use --interactive-console to specify custom IC. Allow for empty command and other minor whitespace annoyances. Console command logging and replay. Support commented lines for replay scripts. Consolidated commands into a command funtion table. Standardized specifying commands, help text, and command groups Provided auto-completion support for commands and object names Various nullptr checks and fixes to avoid segmentation faults. - interactiveConsole.h Add support for shutdown (sstsimulator#1311) - serialization/objectMap.cc, serialization/objectMap.h Support for trace buffers and watchpoint actions Circular buffer and trigger recording Add ability to check/sample before and after both clock and event handlers. Watchpoint support for adding set var val action. Support for trigger comparison between two variables. All set string to handle spaces. watchpoint verbosity control Various bug fixes for command line editing Fixes for nullptr checks and address sanitizer issues causing seg faults. - simulation.cc Interactive console realtime action (sstsimulator#1266) Addition of checkpoint-enable flag to enable checkpoint in IC. Make sst.rt.simpledebug the default for IC replay option for IC - watchPoint.h, watchPoint.cc Circular buffer, trigger record. Add ability to check/sample before and after both clock and event handlers Add watchpoint action class and add set var val action Add support for trigger comparison between two variables Update watchpoint handling Allow set string to handle spaces Add shutdown as trigger action Add watchpoint index to watchpoint class Add checkpoint-enable flag to enable checkpointing in interactive console. Make sst.rt.simpledebug the default for interactive console. Only use --interactive-console to specify a custom IC. watchpoint verbosity control

Major Changes: - config.h, config.cc Add support for interactive realtime action, sst.rt.interactive (sstsimulator#1266) Add checkpoint-enable flag to enable checkpointing in interactive console. Make sst.interactive.simpledebug the default for interactive console and only use --interactive-console to specify a custom IC File replay option ( --replay ) - from_string.h: Full precision printing of float types. Scientific notation when value is greated than 10**6 or less than 10**-6 - impl/interactive/Makefile.inc Included cmdLineEditor files for build - impl/interactive/cmdLineEditor.h, impl/interactive/cmdLineEditor.cc In-line command editing support - impl/interactive/simpleDebug.h, impl/interactive/simpleDebug.cc Shutdown support (sstsimulator#1311) Watchpoint support Add checkpoint-enabled flag to enable in interactive console. Make sst.rtl.simpledebug the default of interactive console. Only use --interactive-console to specify custom IC. Allow for empty command and other minor whitespace annoyances. Console command logging and replay. Support commented lines for replay scripts. Consolidated commands into a command funtion table. Standardized specifying commands, help text, and command groups Provided auto-completion support for commands and object names Various nullptr checks and fixes to avoid segmentation faults. - interactiveConsole.h Add support for shutdown (sstsimulator#1311) - serialization/objectMap.cc, serialization/objectMap.h Support for trace buffers and watchpoint actions Circular buffer and trigger recording Add ability to check/sample before and after both clock and event handlers. Watchpoint support for adding set var val action. Extended trigger tests functionality: support for logic operators (e.g. v1 < 10 && v2 > 5) and comparisons between two variables Support for trigger comparison between two variables. All set string to handle spaces. watchpoint verbosity control Various bug fixes for command line editing Fixes for nullptr checks and address sanitizer issues causing seg faults. - simulation.cc Interactive console realtime action (sstsimulator#1266) Addition of checkpoint-enable flag to enable checkpoint in IC. Make sst.interactive.simpledebug the default for IC replay option for IC - watchPoint.h, watchPoint.cc Circular buffer, trigger record. Add ability to check/sample before and after both clock and event handlers Add watchpoint action class and add set var val action Add support for trigger comparison between two variables Update watchpoint handling Allow set string to handle spaces Add shutdown as trigger action Add watchpoint index to watchpoint class Add checkpoint-enable flag to enable checkpointing in interactive console. Make sst.interactive.simpledebug the default for interactive console. Only use --interactive-console to specify a custom IC. watchpoint verbosity control

* Latest TCL code for interactive console. Major Changes: - config.h, config.cc Add support for interactive realtime action, sst.rt.interactive (#1266) Add checkpoint-enable flag to enable checkpointing in interactive console. Make sst.interactive.simpledebug the default for interactive console and only use --interactive-console to specify a custom IC File replay option ( --replay ) - from_string.h: Full precision printing of float types. Scientific notation when value is greated than 10**6 or less than 10**-6 - impl/interactive/Makefile.inc Included cmdLineEditor files for build - impl/interactive/cmdLineEditor.h, impl/interactive/cmdLineEditor.cc In-line command editing support - impl/interactive/simpleDebug.h, impl/interactive/simpleDebug.cc Shutdown support (#1311) Watchpoint support Add checkpoint-enabled flag to enable in interactive console. Make sst.rtl.simpledebug the default of interactive console. Only use --interactive-console to specify custom IC. Allow for empty command and other minor whitespace annoyances. Console command logging and replay. Support commented lines for replay scripts. Consolidated commands into a command funtion table. Standardized specifying commands, help text, and command groups Provided auto-completion support for commands and object names Various nullptr checks and fixes to avoid segmentation faults. - interactiveConsole.h Add support for shutdown (#1311) - serialization/objectMap.cc, serialization/objectMap.h Support for trace buffers and watchpoint actions Circular buffer and trigger recording Add ability to check/sample before and after both clock and event handlers. Watchpoint support for adding set var val action. Extended trigger tests functionality: support for logic operators (e.g. v1 < 10 && v2 > 5) and comparisons between two variables Support for trigger comparison between two variables. All set string to handle spaces. watchpoint verbosity control Various bug fixes for command line editing Fixes for nullptr checks and address sanitizer issues causing seg faults. - simulation.cc Interactive console realtime action (#1266) Addition of checkpoint-enable flag to enable checkpoint in IC. Make sst.interactive.simpledebug the default for IC replay option for IC - watchPoint.h, watchPoint.cc Circular buffer, trigger record. Add ability to check/sample before and after both clock and event handlers Add watchpoint action class and add set var val action Add support for trigger comparison between two variables Update watchpoint handling Allow set string to handle spaces Add shutdown as trigger action Add watchpoint index to watchpoint class Add checkpoint-enable flag to enable checkpointing in interactive console. Make sst.interactive.simpledebug the default for interactive console. Only use --interactive-console to specify a custom IC. watchpoint verbosity control * comment update * Added watchPoint.h for disti. Required for use with interactiveConsole.h --------- Co-authored-by: Kenneth Griesser <kgriesser@tclcomplabs.com>

github-actions bot added AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) AT: CLANG-FORMAT PASS and removed AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) labels Apr 22, 2025

github-actions bot added the AT: CMAKE-FORMAT PASS label Apr 22, 2025

feldergast added the AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) label Apr 22, 2025

github-actions bot added the AT: CLANG-FORMAT FAIL label May 12, 2025

github-actions bot removed AT: CLANG-FORMAT PASS AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) labels May 12, 2025

Add support for shutdown from interactive console

e441240

skuntz force-pushed the ic_shutdown branch from ebb22f1 to 6fc9fdf Compare May 27, 2025 13:29

github-actions bot added the AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) label May 27, 2025

github-actions bot removed the AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) label May 27, 2025

skuntz added 2 commits May 27, 2025 08:37

Reformat with clang-format v20.1

6293d60

Formatting

7b728cf

skuntz force-pushed the ic_shutdown branch from 6fc9fdf to 7b728cf Compare May 27, 2025 13:38

github-actions bot added AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) AT: CLANG-FORMAT PASS and removed AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) AT: CLANG-FORMAT FAIL labels May 27, 2025

github-actions bot removed the AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) label May 27, 2025

feldergast requested changes May 27, 2025

View reviewed changes

src/sst/core/interactiveConsole.cc Outdated Show resolved Hide resolved

Use endSimulation() for interactiveConsole shutdown

e7de4dd

github-actions bot added AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) and removed AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) labels May 28, 2025

github-actions bot removed the AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) label May 28, 2025

feldergast approved these changes May 28, 2025

View reviewed changes

feldergast added the AT: PRE-TEST INSPECTED label May 28, 2025

sst-autotester removed the AT: PRE-TEST INSPECTED label May 28, 2025

feldergast merged commit fde5e43 into sstsimulator:devel May 28, 2025
7 checks passed

skuntz deleted the ic_shutdown branch September 18, 2025 20:37

kpgriesser mentioned this pull request Oct 21, 2025

Interactive Console Major Update #1452

Merged

Conversation

skuntz commented Apr 22, 2025

Add support to interactiveConsole for an interactiveShutdown function that exits the interactive console and does a clean shutdown of the simulation. This is modeled after the signalShutdown function in simulation.cc and tested in the simpleDebug prototype.

Instructions for Issuing a Pull Request to sst-core

Uh oh!

github-actions bot commented Apr 22, 2025

Uh oh!

github-actions bot commented Apr 22, 2025

Uh oh!

github-actions bot commented May 12, 2025

Uh oh!

github-actions bot commented May 12, 2025

Uh oh!

sst-autotester commented May 12, 2025

Uh oh!

github-actions bot commented May 27, 2025

Uh oh!

github-actions bot commented May 27, 2025

Uh oh!

github-actions bot commented May 27, 2025

Uh oh!

github-actions bot commented May 27, 2025

Uh oh!

sst-autotester commented May 27, 2025

Uh oh!

Uh oh!

github-actions bot commented May 28, 2025

Uh oh!

github-actions bot commented May 28, 2025

Uh oh!

sst-autotester commented May 28, 2025

Uh oh!

sst-autotester commented May 28, 2025

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MR-2

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MT-2

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core_Make-Dist

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements

Using Repos:

Uh oh!

sst-autotester commented May 28, 2025

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MR-2

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MT-2

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core_Make-Dist

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements

Uh oh!

sst-autotester commented May 28, 2025

Uh oh!

sst-autotester commented May 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants