Use more efficient string concatenation #1528
Open
+139
−87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
AT: WIP
|
CLANG-FORMAT TEST - PASSED |
Contributor
|
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is less important than #1518, and should only be merged after it.
This gets rid of warnings generated by
scripts/clang-tidy.sh --checks performance-inefficient-string-concatenation.clang-tidycan detect, but not auto-fix these inefficient string concatenations. I did it by hand, to get rid of the warnings. It is best to append (+=) to astd::stringvariable and thenstd::move()it, than it is to create a large string concatenation expression, because it does not need to allocate and deallocate memory for each temporary string expression, and it only needs to append to the same string variable repeatedly.