TimeConverter updates #1537

feldergast · 2026-01-12T23:09:16Z

Allow TimeConverters to be directly instantiated and simplify APIs that use timebases by allowing implicit conversion of string and UnitAlgebra to TimeConverter instead of having multiple copies of the same function with different parameters. Also cleaned up the basecomponent and timelord source files.

…at use timebases by allowing implicit conversion of string and UnitAlgebra to TimeConverter instead of having multiple copies of the same function with different parameters. Also cleaned up the basecomponent and timelord source files.

github-actions · 2026-01-12T23:09:45Z

CLANG-FORMAT TEST - PASSED

sst-autotester · 2026-01-12T23:21:52Z

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request.

sst-autotester · 2026-01-12T23:25:26Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements

Build Num: 2435
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MR-2

Build Num: 2385
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MT-2

Build Num: 2384
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-core_Make-Dist

Build Num: 1004
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-15-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements

Build Num: 935
Status: STARTED

Using Repos:

Repo: CORE (feldergast/sst-core)

Repo: SQE (sstsimulator/sst-sqe)

Repo: ELEMENTS (sstsimulator/sst-elements)

Repo: MACRO (sstsimulator/sst-macro)

Pull Request Author: feldergast

sst-autotester · 2026-01-13T00:43:18Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements

Build Num: 2435
Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MR-2

Build Num: 2385
Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MT-2

Build Num: 2384
Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-core_Make-Dist

Build Num: 1004
Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-15-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements

Build Num: 935
Status: PASSED

sst-autotester · 2026-01-13T00:43:35Z

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

sst-autotester · 2026-01-13T00:43:41Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sst-autotester · 2026-01-13T04:51:58Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sst-autotester · 2026-01-13T08:52:07Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sst-autotester · 2026-01-13T13:22:07Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sst-autotester · 2026-01-13T17:52:00Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sst-autotester · 2026-01-13T22:22:00Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sst-autotester · 2026-01-14T02:51:55Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sst-autotester · 2026-01-14T06:51:58Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sst-autotester · 2026-01-14T10:52:00Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sst-autotester · 2026-01-14T14:52:14Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sst-autotester · 2026-01-14T18:52:22Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

src/sst/core/simulation.cc

src/sst/core/baseComponent.h

gvoskuilen · 2026-01-14T18:26:57Z

src/sst/core/baseComponent.h

    /**
-       Handles the profile points, default time base, handler tracking
-       and checkpointing.
+       Handles the profile points, default time base, handler tracking and checkpointing.


gvoskuilen · 2026-01-14T18:33:52Z

src/sst/core/baseComponent.h

-     * @param name The name (different from type) for this statistic
-     * @param stat_sub_id An optional sub ID for this statistic to differentiate instances of the same stat
-     * @return The statistic created
+       createStatistic Helper function used to create an enabled statistic. For explicitly-enabled


Remove createStatistic since the @brief is gone.

gvoskuilen · 2026-01-14T18:35:30Z

src/sst/core/baseComponent.h

+
+       This function will register a profiling point.
+
+       @param point Point to register


param name doesn't match name in the function declaration

gvoskuilen · 2026-01-14T20:36:57Z

src/sst/core/timeLord.h

-    std::string        timeBaseString;
-    TimeConverterMap_t tcMap;
-    UnitAlgebra        timeBase;
+    std::string        timeBaseString_;


If you're updating the var format in this class anyways, why not change to underscore separated at the same time?

sst-autotester · 2026-01-14T20:52:21Z

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
THE LAST COMMIT TO THIS PULL REQUEST HAS BEEN REVIEWED, BUT NOT ACCEPTED OR REQUIRES CHANGES!

sst-autotester · 2026-01-14T20:52:28Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

github-actions · 2026-01-14T22:47:06Z

CLANG-FORMAT TEST - PASSED

sst-autotester · 2026-01-14T23:04:32Z

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request.

sst-autotester · 2026-01-14T23:08:28Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements

Build Num: 2439
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MR-2

Build Num: 2389
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MT-2

Build Num: 2388
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-core_Make-Dist

Build Num: 1005
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-15-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements

Build Num: 939
Status: STARTED

Using Repos:

Repo: CORE (feldergast/sst-core)

Repo: SQE (sstsimulator/sst-sqe)

Repo: ELEMENTS (sstsimulator/sst-elements)

Repo: MACRO (sstsimulator/sst-macro)

Pull Request Author: feldergast

sst-autotester · 2026-01-15T01:30:04Z

NOTICE: The AutoTester has encountered an internal error (usually a Communications Timeout), testing will be restarted, previous tests may still be running but will be ignored by the AutoTester...

sst-autotester · 2026-01-15T01:33:25Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements

Build Num: 2441
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MR-2

Build Num: 2391
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MT-2

Build Num: 2390
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-core_Make-Dist

Build Num: 1006
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-15-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements

Build Num: 941
Status: STARTED

Using Repos:

Repo: CORE (feldergast/sst-core)

Repo: SQE (sstsimulator/sst-sqe)

Repo: ELEMENTS (sstsimulator/sst-elements)

Repo: MACRO (sstsimulator/sst-macro)

Pull Request Author: feldergast

sst-autotester · 2026-01-15T02:13:50Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements

Build Num: 2441
Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MR-2

Build Num: 2391
Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MT-2

Build Num: 2390
Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-core_Make-Dist

Build Num: 1006
Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-15-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements

Build Num: 941
Status: PASSED

sst-autotester · 2026-01-15T02:14:08Z

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
THE LAST COMMIT TO THIS PULL REQUEST HAS NOT BEEN REVIEWED YET!

sst-autotester · 2026-01-15T02:14:14Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sst-autotester · 2026-01-15T06:22:48Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sst-autotester · 2026-01-15T10:23:05Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sst-autotester · 2026-01-15T14:53:11Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

gvoskuilen · 2026-01-15T15:50:34Z

src/sst/core/timeConverter.h

+
+       @param time Time to base the TimeConverter on
+     */
+    TimeConverter(const std::string& time); // Implmenented in timeLord.cc


Missed this the first time around "Implemented"

sst-autotester · 2026-01-15T15:58:27Z

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
THE LAST COMMIT TO THIS PULL REQUEST HAS BEEN REVIEWED, BUT NOT ACCEPTED OR REQUIRES CHANGES!

sst-autotester · 2026-01-15T15:58:34Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sst-autotester · 2026-01-15T20:22:02Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

…using the returned pointer to be to a stack allocated TimeConverter instead of the global shared one.

github-actions · 2026-01-15T22:21:21Z

CLANG-FORMAT TEST - PASSED

sst-autotester · 2026-01-15T22:21:57Z

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request.

sst-autotester · 2026-01-15T22:25:39Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements

Build Num: 2442
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MR-2

Build Num: 2392
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MT-2

Build Num: 2391
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-core_Make-Dist

Build Num: 1007
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-15-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements

Build Num: 942
Status: STARTED

Using Repos:

Repo: CORE (feldergast/sst-core)

Repo: SQE (sstsimulator/sst-sqe)

Repo: ELEMENTS (sstsimulator/sst-elements)

Repo: MACRO (sstsimulator/sst-macro)

Pull Request Author: feldergast

sst-autotester · 2026-01-15T23:45:32Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements

Build Num: 2442
Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MR-2

Build Num: 2392
Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MT-2

Build Num: 2391
Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-core_Make-Dist

Build Num: 1007
Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-15-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements

Build Num: 942
Status: PASSED

sst-autotester · 2026-01-15T23:45:49Z

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
THE LAST COMMIT TO THIS PULL REQUEST HAS NOT BEEN REVIEWED YET!

sst-autotester · 2026-01-15T23:45:55Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sst-autotester · 2026-01-16T03:51:58Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sst-autotester · 2026-01-16T07:52:09Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sst-autotester · 2026-01-16T12:21:59Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sst-autotester · 2026-01-16T16:36:35Z

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ gvoskuilen ]!

sst-autotester · 2026-01-16T16:36:42Z

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

feldergast requested a review from gvoskuilen January 12, 2026 23:09

github-actions bot added AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) AT: CLANG-FORMAT PASS and removed AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) labels Jan 12, 2026

gvoskuilen requested changes Jan 14, 2026

View reviewed changes

Formatting changes and variable name updates

5f0e75c

github-actions bot added AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) and removed AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) labels Jan 14, 2026

gvoskuilen reviewed Jan 15, 2026

View reviewed changes

Fix bug in Simualtion_impl::registerClock(TimeConverter&) that was ca…

6f3e590

…using the returned pointer to be to a stack allocated TimeConverter instead of the global shared one.

github-actions bot added AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) and removed AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) labels Jan 15, 2026

gvoskuilen approved these changes Jan 16, 2026

View reviewed changes

feldergast merged commit a22928b into sstsimulator:devel Jan 16, 2026
10 checks passed

feldergast deleted the timeconverter-update branch January 16, 2026 17:44


		This function will register a profiling point.

		@param point Point to register

TimeConverter updates #1537

TimeConverter updates #1537

Uh oh!

Conversation

feldergast commented Jan 12, 2026

Uh oh!

github-actions bot commented Jan 12, 2026

Uh oh!

sst-autotester commented Jan 12, 2026

Uh oh!

sst-autotester commented Jan 12, 2026

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MR-2

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MT-2

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-core_Make-Dist

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-15-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements

Using Repos:

Uh oh!

sst-autotester commented Jan 13, 2026

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MR-2

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MT-2

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-core_Make-Dist

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-15-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements

Uh oh!

sst-autotester commented Jan 13, 2026

Uh oh!

sst-autotester commented Jan 13, 2026

Uh oh!

sst-autotester commented Jan 13, 2026

Uh oh!

sst-autotester commented Jan 13, 2026

Uh oh!

sst-autotester commented Jan 13, 2026

Uh oh!

sst-autotester commented Jan 13, 2026

Uh oh!

sst-autotester commented Jan 13, 2026

Uh oh!

sst-autotester commented Jan 14, 2026

Uh oh!

sst-autotester commented Jan 14, 2026

Uh oh!

sst-autotester commented Jan 14, 2026

Uh oh!

sst-autotester commented Jan 14, 2026

Uh oh!

sst-autotester commented Jan 14, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gvoskuilen Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

gvoskuilen Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

gvoskuilen Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

gvoskuilen Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

sst-autotester commented Jan 14, 2026

Uh oh!

sst-autotester commented Jan 14, 2026