fix: Refresh flashcard modal after edit and general QOL improvements to editing#1010
Open
brendan-ch wants to merge 8 commits intost3v3nmw:masterfrom
Open
fix: Refresh flashcard modal after edit and general QOL improvements to editing#1010brendan-ch wants to merge 8 commits intost3v3nmw:masterfrom
brendan-ch wants to merge 8 commits intost3v3nmw:masterfrom
Conversation
brendan-ch
changed the title
KyleKlus
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses #718, #686 by updating the card and review modal after a card is edited.
I also added handling of edge cases where the front/back of a card is missing after the edit, or the number of Cloze cards is different. This was needed for my fix, but I'd be happy to try another approach; just let me know.
Screenshots of Notices
This notice displays if the front or back side is missing after an edit (e.g. the entire card is deleted by accident).
This one displays if the number of Cloze cards changes.