update date format to YYYY-MM-DD-HH-mm and support review before due #614
Conversation
| } | ||
|
|
||
| const dueString: string = due.format("YYYY-MM-DD"); | ||
| const dueString: string = due.format("YYYY-MM-DD-HH-mm"); |
There was a problem hiding this comment.
Isn't the YYYY-MM-DD HH:mm format better and more readable?
There was a problem hiding this comment.
I would probably suggest using one of the ISO 8601 formats, e.g. YYYY-MM-DDTHH:mm (i.e. the literal T between the date and time)
st3v3nmw
left a comment
st3v3nmw
left a comment
There was a problem hiding this comment.
Hi, thanks for the contribution 😄!
Sorry the underlying code has gone through a major refactor recently. I'm not sure if you're still available to help resolve the merge conflicts.
Stephen,
|
|
||
| const due = window.moment(now + interval * 24 * 3600 * 1000); | ||
| const dueString: string = due.format("YYYY-MM-DD"); | ||
| const dueString: string = due.format("YYYY-MM-DD-HH-mm"); |
There was a problem hiding this comment.
I would suggest that the time component is only included if necessary. This would keep the HTML commands in the current format, and only the longer format when needed.
|
Hi @newle, nice idea in your PR. There seems to be similarity in purpose between your PR and #569. Both aim to provide a mechanism so that newly learned cards can be reviewed the same day (or multiple times that day). @st3v3nmw and I are hoping to work through the outstanding PR requests, but we might only want to incorporate either your PR or #569. Can you think of a case where your method gives a better user experience over #569? Also I'm curious what value for Thanks |
|
Unfortunately no response from OP for 6 months, closing this now. |
3 participants
No description provided.