Added support for flashcards within Admonition style code blocks

[DanielChicoUGR]

Description:

As described in issue #747 , support for flashcards within Admonition style code blocks has been added. The plugin is now able to detect cards inside code blocks with ad-* style indicator, among impklemented in ad-monition pluggin

Changes:

• Modification of the parser function to skip those blocks of code that do not begin with: "```ad-" or "~~~ad-"

[ronzulu]

Hi @DanielChicoUGR, nice one!

I haven't had a chance to test this, but a couple of comments in the meantime:

Please include new unit test cases within parser.test.ts

About terminology, IMHO saying "Added integration with the Admonition Pluggin" implies actual integration with that plug-in, which isn't accurate. I think "Added support for flashcards within Admonition style code blocks" is more accurate.

There is a chance that the enhancement could break existing notes. This would occur if someone had included within an admonition code block something that matched any of the recognized card formats. Something that they didn't want to be treated as a card, and up till now hasn't been, e.g. typedef std::vector<Board> t_bvector;

Perhaps we need to make this new behavior optional.

Cheers
Ronny

[DanielChicoUGR]

kk, U right in both cases, i will work on this today and add some unit test too.

One Question only, is it possible to modify this pr or may i reopen other pr and close this?? (Noob doubts sry)

thanks for the time and attention, cheers Daniel

[ronzulu]

Hi Daniel, looking forward to the update 😄

Do you have an edit button at the top of this page? I see the following:

Recently I was granted "collaborator" permissions, that's why I can edit someone else's PR.

I assume that before I became a collaborator that I would have been able to edit any PR that I opened, but don't explicitly remember.

If you can't edit, then I think it's better if you let me know what changes you want and I will make them (easier than closing this PR and opening another)

Cheers
Ronny