support @phpstandba-inference-placeholder on static method calls (#432)

Author: staabm

src/QueryReflection/QueryReflection.php

@@ -7,6 +7,7 @@
 use PhpParser\Node\Expr;
 use PhpParser\Node\Expr\BinaryOp\Concat;
 use PhpParser\Node\Identifier;
+use PhpParser\Node\Name;
 use PHPStan\Analyser\Scope;
 use PHPStan\ShouldNotHappenException;
 use PHPStan\Type\Constant\ConstantArrayType;
@@ -187,13 +188,21 @@ private function resolveQueryExpr(Expr $queryExpr, Scope $scope): ?string
      */
     private function resolveQueryStringExpr(Expr $queryExpr, Scope $scope): ?string
     {
-        if ($queryExpr instanceof Expr\MethodCall && $queryExpr->name instanceof Identifier) {
-            $classReflection = $scope->getClassReflection();
-
-            // XXX atm we only support inference-placeholder for method calls within the same class
-            if (null !== $classReflection && $classReflection->hasMethod($queryExpr->name->name)) {
-                $methodReflection = $classReflection->getMethod($queryExpr->name->name, $scope);
+        if ($queryExpr instanceof Expr\CallLike) {
+            $methodReflection = null;
+            if ($queryExpr instanceof Expr\StaticCall) {
+                if ($queryExpr->class instanceof Name && $queryExpr->name instanceof Identifier) {
+                    $classType = $scope->resolveTypeByName($queryExpr->class);
+                    $methodReflection = $scope->getMethodReflection($classType, $queryExpr->name->name);
+                }
+            } elseif ($queryExpr instanceof Expr\MethodCall && $queryExpr->name instanceof Identifier) {
+                $classReflection = $scope->getClassReflection();
+                if (null !== $classReflection && $classReflection->hasMethod($queryExpr->name->name)) {
+                    $methodReflection = $classReflection->getMethod($queryExpr->name->name, $scope);
+                }
+            }
 
+            if (null !== $methodReflection) {
                 // atm no resolved phpdoc for methods
                 // see https://github.com/phpstan/phpstan/discussions/7657
                 $phpDocString = $methodReflection->getDocComment();

tests/default/data/inference-placeholder.php

@@ -12,6 +12,10 @@ public function fetchOneWithDynamicQueryPart(Connection $conn, string $email)
         $query = 'SELECT email, adaid FROM ada WHERE email = :email AND '.$this->dynamicWhere(rand(0, 100));
         $fetchResult = $conn->fetchOne($query, ['email' => $email]);
         assertType('string|false', $fetchResult);
+
+        $query = 'SELECT email, adaid FROM ada WHERE email = :email AND '.self::dynamicWhere(rand(0, 100));
+        $fetchResult = $conn->fetchOne($query, ['email' => $email]);
+        assertType('string|false', $fetchResult);
     }
 
     /**
@@ -31,4 +35,22 @@ private function dynamicWhere(int $i)
 
         return implode(' AND ', $where);
     }
+
+    /**
+     * simulating a dynamic where part, not relevant for the query overall result.
+     *
+     * @phpstandba-inference-placeholder '1=1'
+     *
+     * @return string
+     */
+    private static function staticDynamicWhere(int $i)
+    {
+        $where = ['1=1'];
+
+        if ($i > 100) {
+            $where[] = 'adaid = '.$i.'';
+        }
+
+        return implode(' AND ', $where);
+    }
 }