enforce strict comparison (#260)

Co-authored-by: Markus Staab <[email protected]>

Author: staabm

.php-cs-fixer.dist.php

@@ -16,6 +16,7 @@
     ->setRules([
         '@Symfony' => true,
         '@Symfony:risky' => true,
+        'strict_param' => true,
         'array_syntax' => ['syntax' => 'short'],
         'fopen_flags' => false,
         'ordered_imports' => true,

src/Extensions/PdoStatementFetchDynamicReturnTypeExtension.php

@@ -74,7 +74,7 @@ private function inferType(MethodReflection $methodReflection, MethodCall $metho
             }
             $fetchType = $fetchModeType->getValue();
 
-            if (!\in_array($fetchType, [PDO::FETCH_ASSOC, PDO::FETCH_NUM, PDO::FETCH_BOTH])) {
+            if (!\in_array($fetchType, [PDO::FETCH_ASSOC, PDO::FETCH_NUM, PDO::FETCH_BOTH], true)) {
                 return null;
             }
         }

src/PdoReflection/PdoStatementReflection.php

@@ -34,9 +34,7 @@ public function findPrepareQueryStringExpression(MethodReflection $methodReflect
     }
 
     /**
-     * // the following param doesnt work, see phpstan bug https://github.com/phpstan/phpstan/issues/6577.
-     *
-     * @xx-param PDO::FETCH* $fetchType
+     * @param PDO::FETCH* $fetchType
      *
      * @return Type|null
      */

src/QueryReflection/ChainedReflector.php

@@ -31,7 +31,7 @@ public function validateQueryString(string $queryString): ?Error
 
             // on "not found" error, we try the next reflector.
             if ($reflectorError) {
-                if (!\in_array($reflectorError->getCode(), [MysqliQueryReflector::MYSQL_UNKNOWN_TABLE])) {
+                if (!\in_array($reflectorError->getCode(), [MysqliQueryReflector::MYSQL_UNKNOWN_TABLE], true)) {
                     return $reflectorError;
                 }
                 if (true === $nooneKnows) {

src/QueryReflection/PlaceholderValidation.php

@@ -111,7 +111,7 @@ private function validateNamedPlaceholders(string $queryString, array $parameter
             if ($parameter->isOptional) {
                 continue;
             }
-            if (!\in_array($placeholderKey, $namedPlaceholders)) {
+            if (!\in_array($placeholderKey, $namedPlaceholders, true)) {
                 yield sprintf('Value %s is given, but the query does not contain this placeholder.', $placeholderKey);
             }
         }