Skip to content

Conversation

@m-mohr
Copy link
Contributor

@m-mohr m-mohr commented Jan 3, 2022

I made quite a number of tests to check that the JSON Schema works in different scenarios and couldn't find any issues.

May supersede a couple of existing PRs (#6, #9) as I think the JSON Schemas in those PRs don't fully capture all issues and it could avoid the unit tests, it seems better to have tests in JSON Schemas so that other tooling (PySTAC, validators) can make use of it. @l0b0

I hope that we can release a 1.1.0 of the extension after this has been merged.

Copy link
Member

@emmanuelmathot emmanuelmathot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as it validates the examples. To be honest, I tried to review the new schemas but I must admit it goes beyond my expertise.

@m-mohr m-mohr merged commit 3f2043e into main Jan 7, 2022
@m-mohr m-mohr deleted the fix-schema-validation branch January 7, 2022 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How should asset processing properties be validated? Bug: Invalid collection properties are treated as valid if there are some valid values

3 participants