Merged
Conversation
Member
Author
|
🤔 well tests pass! |
Member
Author
|
@bitner I'm not sure to understand how the CI is design, thus I'm not sure that pgtap was ran with my last commit |
Collaborator
|
Yeah, it doesn't look like tests ran at all. |
bitner
approved these changes
Oct 14, 2024
Collaborator
|
In 'Files changed' tab I see changes that were already merged to the |
Collaborator
|
Ah that makes sense because it was never included in the migrations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
while working on stac-utils/stac-fastapi-pgstac#155 we encountered some strange behaviour with the next/prev links returned by pgstac
The first commit of this PR adds tests showing what I was expecting from pgstac
cc @bitner
Note: in tipg this is how we determine next/prev links https://github.com/developmentseed/tipg/blob/ea1ef949873abb7886811dce85a47913f38e3e38/tipg/collections.py#L783-L788