Skip to content

Conversation

@jsignell
Copy link
Member

Related Issue(s):

Description:

Not sure if throwing a different error counts as a breaking change :)

PR Checklist:

  • Pre-commit hooks and tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@codecov
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.46%. Comparing base (bc5eae4) to head (363a313).
Report is 31 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1500      +/-   ##
==========================================
+ Coverage   91.44%   91.46%   +0.01%     
==========================================
  Files          54       54              
  Lines        7505     7509       +4     
  Branches      906      906              
==========================================
+ Hits         6863     6868       +5     
  Misses        457      457              
+ Partials      185      184       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if throwing a different error counts as a breaking change :)

Nah. Good thought, but bringing the error "in-house" by making it a STACError feels more like a bugfix to me :-P

Think this needs a changelog? Happy either way.

@jsignell jsignell enabled auto-merge January 22, 2025 14:45
@jsignell jsignell added this pull request to the merge queue Jan 22, 2025
Merged via the queue into stac-utils:main with commit 67931b5 Jan 22, 2025
23 checks passed
@jsignell jsignell deleted the better-error branch January 22, 2025 14:53
kmodali pushed a commit to kmodali/pystac that referenced this pull request Oct 16, 2025
* Better error message when link does not resolve

* Skip test on windows

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Better error messages when a link is expected to resolve to a STAC object but doesn't

2 participants